Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2969203002: Drop unused member loader_ in testing file SimRequest.h (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unused member loader_ in testing file SimRequest.h This caused compilation errors (through a compiler warning) in jumbo builds. I speculate that if the compiler (clang) sees both an object creation and the full declaration it will complain about members that are never accessed. R=fs@opera.com Review-Url: https://codereview.chromium.org/2969203002 Cr-Commit-Position: refs/heads/master@{#484224} Committed: https://chromium.googlesource.com/chromium/src/+/586ebf48c1bd0bcd86ad0fa491e571270b71c6f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/testing/sim/SimRequest.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Daniel Bratell
fs, PTAL.
3 years, 5 months ago (2017-07-05 07:57:35 UTC) #3
fs
lgtm
3 years, 5 months ago (2017-07-05 08:00:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969203002/1
3 years, 5 months ago (2017-07-05 08:25:00 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 09:11:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/586ebf48c1bd0bcd86ad0fa491e5...

Powered by Google App Engine
This is Rietveld 408576698