Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2969183002: Use FrameSelection::Granularity in TextControlElement::ComputeSelection{Start,End}() (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FrameSelection::Granularity in TextControlElement::ComputeSelection{Start,End}() This patch changes |TextControlElement::ComputeSelection{Start,End}()| to use |FrameSelection::Granularity()| instead of |VisibleSelection::Granularity()| as a preparation of getting rid of |VisibleSelection::Granularity()|. BUG=692923 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2969183002 Cr-Commit-Position: refs/heads/master@{#484218} Committed: https://chromium.googlesource.com/chromium/src/+/28c838c598c2e513ac94512f828c4ee43af4e5d6

Patch Set 1 : 2017-07-05T15:47:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-07-05 07:50:45 UTC) #6
tkent
lgtm
3 years, 5 months ago (2017-07-05 07:58:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969183002/1
3 years, 5 months ago (2017-07-05 07:59:53 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 08:38:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28c838c598c2e513ac94512f828c...

Powered by Google App Engine
This is Rietveld 408576698