chrome/browser/android/webapps/add_to_homescreen_manager.cc - Issue 2969163002: Remove AppBannerManager::event_request_id().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2969163002: Remove AppBannerManager::event_request_id(). (Closed)

Patch Set: Refactor into method Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc

index 17be74754228df42db24c3813bb941a51c9fa773..d3f787abcfe3dd7c716d1b917f039a91e0c76ea0 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc

@@ -186,8 +186,7 @@ void AddToHomescreenManager::CreateInfoBarForWebApk(

banners::AppBannerInfoBarDelegateAndroid::Create(

web_contents, app_banner_manager->GetWeakPtr(),

base::MakeUnique<ShortcutInfo>(info), primary_icon, badge_icon,

- -1 /* event_request_id */, true /* is_webapk */,

- webapk::INSTALL_SOURCE_MENU);

+ true /* is_webapk */, webapk::INSTALL_SOURCE_MENU);

}

SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground(