Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1451)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2969163002: Remove AppBannerManager::event_request_id(). (Closed)
Patch Set: Refactor into method Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index f50e444cf6cea7165e1d9e932287d927168345db..967a2758bc5c69bec129069421e97fe9a77b25c7 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -249,7 +249,7 @@ void AppBannerManagerAndroid::ShowBanner() {
contents, GetWeakPtr(),
CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
badge_icon_url_, can_install_webapk_),
- primary_icon_, badge_icon_, event_request_id(), can_install_webapk_,
+ primary_icon_, badge_icon_, can_install_webapk_,
webapk::INSTALL_SOURCE_BANNER)) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
@@ -260,7 +260,7 @@ void AppBannerManagerAndroid::ShowBanner() {
} else {
if (AppBannerInfoBarDelegateAndroid::Create(
contents, native_app_title_, native_app_data_, primary_icon_,
- native_app_package_, referrer_, event_request_id())) {
+ native_app_package_, referrer_)) {
RecordDidShowBanner("AppBanner.NativeApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);
ReportStatus(contents, SHOWING_NATIVE_APP_BANNER);

Powered by Google App Engine
This is Rietveld 408576698