Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 296913002: Revert 271905 "Roll pdfium to get fixes for build warnings." (Closed)

Created:
6 years, 7 months ago by jam
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271905 "Roll pdfium to get fixes for build warnings." > Roll pdfium to get fixes for build warnings. > > a3f590b Add Matt Giuca to AUTHORS. > 4db62f5 Fixed or silenced all warnings and turned on warnings-as-errors. > 2c4b046 cf2hints: Fix early loop termination causing hints to be ignored. > 4fbe779 Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning. > 6f9095f Add my @chromium account in the AUTHORS file. > 54c1825 Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors. > 5ce98f5 Fix warning on Mac. > 41f0590 Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library. > > R=thestig@chromium.org > > Review URL: https://codereview.chromium.org/295983005 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
6 years, 7 months ago (2014-05-21 16:03:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698