Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 295983005: Roll pdfium to get fixes for build warnings. (Closed)

Created:
6 years, 7 months ago by jam
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Roll pdfium to get fixes for build warnings. a3f590b Add Matt Giuca to AUTHORS. 4db62f5 Fixed or silenced all warnings and turned on warnings-as-errors. 2c4b046 cf2hints: Fix early loop termination causing hints to be ignored. 4fbe779 Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning. 6f9095f Add my @chromium account in the AUTHORS file. 54c1825 Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors. 5ce98f5 Fix warning on Mac. 41f0590 Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library. R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272522

Patch Set 1 #

Patch Set 2 : reupload after revert #

Patch Set 3 : #

Patch Set 4 : reupload after revert #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
6 years, 7 months ago (2014-05-20 21:40:52 UTC) #1
Lei Zhang
lgtm Drop the "by Foo - N minutes ago" bits from the commit msg?
6 years, 7 months ago (2014-05-20 22:43:16 UTC) #2
jam
6 years, 7 months ago (2014-05-21 15:57:14 UTC) #3
On 2014/05/20 22:43:16, Lei Zhang wrote:
> lgtm
> 
> Drop the "by Foo - N minutes ago" bits from the commit msg?

done

Powered by Google App Engine
This is Rietveld 408576698