Forward BrowserAccessibilityWin table APIs to AXPlatformNodeWin.

Forward BrowserAccessibilityWin table APIs to AXPlatformNodeWin.

This CL implements IAccessibleTable, IAccessibleTable2 and
IAccessibleTableCell on AXPlatformNodeWin. It forwards calls on
BrowserAccessibilityWin to this implementation.

BUG=703369
Review-Url: https://codereview.chromium.org/2969113002
Cr-Commit-Position: refs/heads/master@{#485996}
Committed: https://chromium.googlesource.com/chromium/src/+/63ad8c63891cf5c19e7742f1b72940937c6c9784

[dougt, 2017-07-04 17:43:29]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 17:43:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-07-04 17:44:52]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dougt, 2017-07-04 17:44:52]

dmazzoni, ptal.

[commit-bot: I haz the power, 2017-07-04 19:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 19:34:25]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dougt, 2017-07-04 20:07:45]

On 2017/07/04 17:44:52, dougt wrote:
> dmazzoni, ptal.

I'll debug TestIAccessibleTableCellGetRowHeaderCells later this week.  :)

[dougt, 2017-07-05 03:48:05]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 03:48:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 03:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 03:50:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dougt, 2017-07-05 04:04:50]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 04:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 04:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 04:50:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2017-07-06 23:03:25]

lgtm

https://codereview.chromium.org/2969113002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_com_win.cc (right):

https://codereview.chromium.org/2969113002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_com_win.cc:1071:
STDMETHODIMP BrowserAccessibilityComWin::get_accessibleAt(
I'm confused as to why we still have get_accessibleAt
Since BrowserAccessibilityComWin inherits from
AXPlatformNodeWin, can't we get the implementation
directly from that class?

https://codereview.chromium.org/2969113002/diff/40001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win_unittest.cc (right):

https://codereview.chromium.org/2969113002/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win_unittest.cc:151: void
Build4X4Table() {
Very nice! But it's 3x3, right?

[dougt, 2017-07-11 23:25:41]

https://codereview.chromium.org/2969113002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_com_win.cc (right):

https://codereview.chromium.org/2969113002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_com_win.cc:1071:
STDMETHODIMP BrowserAccessibilityComWin::get_accessibleAt(
On 2017/07/06 23:03:24, dmazzoni_ooo_until_july_17 wrote:
> I'm confused as to why we still have get_accessibleAt
> Since BrowserAccessibilityComWin inherits from
> AXPlatformNodeWin, can't we get the implementation
> directly from that class?

Acknowledged.

Very good question. The short answer is soon we will remove most (all?) the
windows interfaces on BrowserAccessibilityComWin and just inherit from
AXPlatformNodeWin.  We need to solve a few things.  First we need to figure out
what we should do with the histrograms.  Right now, we are recording API usage
(see line 1075 below).  I am not sure if we want to do this in the ax platform
side (but we might).  Something to think about.

The other thing we have to do is figure out what to do about setting the mode
flags (see line 1076).  I think, maybe, we should just flip the flags anytime
anything tickles any accessibility API.  Again, nothing really hard just
something to think about.

Longer term and many follow ups from now, I want to make it so that
BrowserAccessibilityComWin is basically just a delegate and most functionality
just lives in the platform node.

https://codereview.chromium.org/2969113002/diff/40001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win_unittest.cc (right):

https://codereview.chromium.org/2969113002/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win_unittest.cc:151: void
Build4X4Table() {
On 2017/07/06 23:03:24, dmazzoni_ooo_until_july_17 wrote:
> Very nice! But it's 3x3, right?

off by one! :)

[dougt, 2017-07-12 07:18:16]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-07-12 07:18:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2969113002/#ps60001
(title: "Rename 4X4 to 3X3. Off by one!")

[commit-bot: I haz the power, 2017-07-12 07:18:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 07:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 07:59:43]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dougt, 2017-07-12 15:29:22]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-07-12 15:29:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 16:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499873362126300,
"parent_rev": "4472abcc2335fd7e35bd8d3ef2c11b6306cd90d7", "commit_rev":
"63ad8c63891cf5c19e7742f1b72940937c6c9784"}

[commit-bot: I haz the power, 2017-07-12 16:51:36]

Description was changed from

==========
Forward BrowserAccessibilityWin table APIs to AXPlatformNodeWin.

This CL implements IAccessibleTable, IAccessibleTable2 and
IAccessibleTableCell on AXPlatformNodeWin. It forwards calls on
BrowserAccessibilityWin to this implementation.

BUG=703369
==========

to

==========
Forward BrowserAccessibilityWin table APIs to AXPlatformNodeWin.

This CL implements IAccessibleTable, IAccessibleTable2 and
IAccessibleTableCell on AXPlatformNodeWin. It forwards calls on
BrowserAccessibilityWin to this implementation.

BUG=703369

Review-Url: https://codereview.chromium.org/2969113002
Cr-Commit-Position: refs/heads/master@{#485996}
Committed:
https://chromium.googlesource.com/chromium/src/+/63ad8c63891cf5c19e7742f1b729...
==========

[commit-bot: I haz the power, 2017-07-12 16:51:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/63ad8c63891cf5c19e7742f1b729...