Add most equivalence tests to js_model/model_test

Add most equivalence tests to js_model/model_test

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/2c671d6a1b5eebd3f1a3c8aa04d496f96525855b

[Johnni Winther, 2017-07-04 14:25:14]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-05 21:25:53]

https://codereview.chromium.org/2969073002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2969073002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:72: interceptedMembers[name] =
members.map(_map.toBackendMember).toSet();
since we have a few of these conversions here and in a few other places, it
might be worth adding a couple helper methods... 

  convertList(l) => l.map(_map.toBackendMember).toList();
  convertSet(s) => l.map(_map.toBackendMember).toSet();
  convertMapOfSets(m) {
    var m2 = {};
    m.forEach((k, v) => m2[k] = convertSet(v);
  }

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
File tests/compiler/dart2js/js_model/model_test.dart (right):

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
tests/compiler/dart2js/js_model/model_test.dart:39: verbose: arguments.verbose,
I think I'm missing something: with this change I don't see where you create the
JsBackendStrategy?

[Johnni Winther, 2017-07-06 14:53:40]

PTAL

https://codereview.chromium.org/2969073002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2969073002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:72: interceptedMembers[name] =
members.map(_map.toBackendMember).toSet();
On 2017/07/05 21:25:52, Siggi Cherem (dart-lang) wrote:
> since we have a few of these conversions here and in a few other places, it
> might be worth adding a couple helper methods... 
> 
>   convertList(l) => l.map(_map.toBackendMember).toList();
>   convertSet(s) => l.map(_map.toBackendMember).toSet();
>   convertMapOfSets(m) {
>     var m2 = {};
>     m.forEach((k, v) => m2[k] = convertSet(v);
>   }

Sometimes we convert members, sometimes classes. We would need to parameters
such method so it doesn't really pay off.

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
File tests/compiler/dart2js/js_model/model_test.dart (right):

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
tests/compiler/dart2js/js_model/model_test.dart:39: verbose: arguments.verbose,
On 2017/07/05 21:25:53, Siggi Cherem (dart-lang) wrote:
> I think I'm missing something: with this change I don't see where you create
the
> JsBackendStrategy?

By `useJsStrategyForTesting = true;` in line 12.

[Siggi Cherem (dart-lang), 2017-07-06 17:47:46]

lgtm

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
File tests/compiler/dart2js/js_model/model_test.dart (right):

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
tests/compiler/dart2js/js_model/model_test.dart:39: verbose: arguments.verbose,
On 2017/07/06 14:53:40, Johnni Winther wrote:
> On 2017/07/05 21:25:53, Siggi Cherem (dart-lang) wrote:
> > I think I'm missing something: with this change I don't see where you create
> the
> > JsBackendStrategy?
> 
> By `useJsStrategyForTesting = true;` in line 12.

Ah! thanks, indeed that's what I missed. I recall when you added it, but missed
that the line overriding JsBackendStrategy here (the `beforeRun` on the left)
was probably not necessary anymore, correct?

[Johnni Winther, 2017-07-07 08:23:36]

Description was changed from

==========
Add most equivalence tests to js_model/model_test
==========

to

==========
Add most equivalence tests to js_model/model_test

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2c671d6a1b5eebd3f1a3c8aa04d496f96525855b
==========

[Johnni Winther, 2017-07-07 08:23:39]

Committed patchset #1 (id:1) manually as
2c671d6a1b5eebd3f1a3c8aa04d496f96525855b (presubmit successful).

[Johnni Winther, 2017-07-07 08:23:50]

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
File tests/compiler/dart2js/js_model/model_test.dart (right):

https://codereview.chromium.org/2969073002/diff/1/tests/compiler/dart2js/js_m...
tests/compiler/dart2js/js_model/model_test.dart:39: verbose: arguments.verbose,
On 2017/07/06 17:47:46, Siggi Cherem (dart-lang) wrote:
> On 2017/07/06 14:53:40, Johnni Winther wrote:
> > On 2017/07/05 21:25:53, Siggi Cherem (dart-lang) wrote:
> > > I think I'm missing something: with this change I don't see where you
create
> > the
> > > JsBackendStrategy?
> > 
> > By `useJsStrategyForTesting = true;` in line 12.
> 
> Ah! thanks, indeed that's what I missed. I recall when you added it, but
missed
> that the line overriding JsBackendStrategy here (the `beforeRun` on the left)
> was probably not necessary anymore, correct?

Yes. I just forgot to remove it earlier.