Add most equivalence tests to js_model/model_test

tests/compiler/dart2js/js_model/model_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'package:async_helper/async_helper.dart';
-import 'package:compiler/src/commandline_options.dart';
-import 'package:compiler/src/common.dart';
-import 'package:compiler/src/compiler.dart';
 import 'package:compiler/src/kernel/kernel_backend_strategy.dart';
-import 'package:compiler/src/js_model/js_strategy.dart';
-import 'package:expect/expect.dart';
 import '../kernel/compile_from_dill_test_helper.dart';
-import '../kernel/compiler_helper.dart';
 import '../serialization/helper.dart';
 
 main(List<String> args) {
   useJsStrategyForTesting = true;
   asyncTest(() async {
     await mainInternal(args);
   });
 }
 
 Future mainInternal(List<String> args,
     {bool skipWarnings: false,
     bool skipErrors: false,
     List<String> options: const <String>[]}) async {
   Arguments arguments = new Arguments.from(args);
   List<Test> tests;
   if (arguments.uri != null) {
     tests = <Test>[new Test.fromUri(arguments.uri)];
   } else {
     tests = TESTS;
   }
   for (Test test in tests) {
     if (test.uri != null) {
       print('--- running test uri ${test.uri} -------------------------------');
     } else {
       print(
           '--- running test code -------------------------------------------');
       print(test.sources.values.first);
       print('----------------------------------------------------------------');
     }
-
-    enableDebugMode();
-
-    Compiler compiler1 = await compileWithDill(test.entryPoint, test.sources, [
-      Flags.disableInlining,
-      Flags.disableTypeInference
-    ], beforeRun: (Compiler compiler) {
-      compiler.backendStrategy = new JsBackendStrategy(compiler);
-    }, printSteps: true);
-    Expect.isFalse(compiler1.compilationFailed);
+    await runTest(test.entryPoint, test.sources,
+        verbose: arguments.verbose,

[Siggi Cherem (dart-lang), 2017/07/05 21:25:53]

I think I'm missing something: with this change I don't see where you create the
JsBackendStrategy?

[Johnni Winther, 2017/07/06 14:53:40]

By `useJsStrategyForTesting = true;` in line 12.

[Siggi Cherem (dart-lang), 2017/07/06 17:47:46]

Ah! thanks, indeed that's what I missed. I recall when you added it, but missed
that the line overriding JsBackendStrategy here (the `beforeRun` on the left)
was probably not necessary anymore, correct?

[Johnni Winther, 2017/07/07 08:23:50]

Yes. I just forgot to remove it earlier.

+        skipWarnings: skipWarnings,
+        skipErrors: skipErrors,
+        options: options,
+        expectAstEquivalence: false,
+        expectIdenticalOutput: false);
   }
 }