Remove temporary VP9 pid/tl0 jump fix.

Remove temporary VP9 pid/tl0 jump fix.

Earlier the pid/tl0 was incorrectly reinitialized upon encoder reconfiguration,
and this fix was implemented to mitigate that. This fix can however guess wrong
and cause a valid stream to be interupted.

BUG=webrtc:7920
Review-Url: https://codereview.webrtc.org/2969043002
Cr-Commit-Position: refs/heads/master@{#19268}
Committed: https://chromium.googlesource.com/external/webrtc/+/bb992e71594e77f2c43a3bfad77ba2627a5bd81e

[philipel, 2017-07-04 13:24:11]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[philipel, 2017-07-04 13:58:27]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 13:58:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-04 14:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 14:20:45]

Dry run: This issue passed the CQ dry run.

[holmer, 2017-07-05 07:34:56]

holmer@google.com changed reviewers:
+ holmer@google.com

[holmer, 2017-07-05 07:34:56]

Have we verified that this is now OK to remove with manual tests?

[philipel, 2017-07-05 11:26:29]

Yes, I ran video_loopback with various settings and the pid/tl0 no longer jumps
on reinitialization, also tested in chrome
--force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL with
https://sfu.medooze.com/svc/.

[stefan-webrtc, 2017-07-05 11:43:12]

On 2017/07/05 11:26:29, philipel wrote:
> Yes, I ran video_loopback with various settings and the pid/tl0 no longer
jumps
> on reinitialization, also tested in chrome
> --force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL with
> https://sfu.medooze.com/svc/.

In which Chrome version was it fixed?

[philipel, 2017-07-05 13:23:00]

On 2017/07/05 11:43:12, stefan-webrtc wrote:
> On 2017/07/05 11:26:29, philipel wrote:
> > Yes, I ran video_loopback with various settings and the pid/tl0 no longer
> jumps
> > on reinitialization, also tested in chrome
> > --force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL with
> > https://sfu.medooze.com/svc/.
> 
> In which Chrome version was it fixed?

I tested it on ToT, but the CL that fixed the reinitialization problems landed
2017-05-03 (https://codereview.webrtc.org/2833493003).

[philipel, 2017-08-01 13:01:00]

I looked at what had to be done to fix the jump-fix, and I don't think it's
worth it.

[philipel, 2017-08-08 10:46:11]

ping

[stefan-webrtc, 2017-08-08 12:27:34]

lgtm, but we should send out a PSA about this.

[philipel, 2017-08-08 12:49:32]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-08-08 12:49:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-08 13:18:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502196572452150, "parent_rev":
"007d56229adb8933960bfb08af1090ec20d48072", "commit_rev":
"bb992e71594e77f2c43a3bfad77ba2627a5bd81e"}

[commit-bot: I haz the power, 2017-08-08 13:19:02]

Description was changed from

==========
Remove temporary VP9 pid/tl0 jump fix.

Earlier the pid/tl0 was incorrectly reinitialized upon encoder reconfiguration,
and this fix was implemented to mitigate that. This fix can however guess wrong
and cause a valid stream to be interupted.

BUG=webrtc:7920
==========

to

==========
Remove temporary VP9 pid/tl0 jump fix.

Earlier the pid/tl0 was incorrectly reinitialized upon encoder reconfiguration,
and this fix was implemented to mitigate that. This fix can however guess wrong
and cause a valid stream to be interupted.

BUG=webrtc:7920

Review-Url: https://codereview.webrtc.org/2969043002
Cr-Commit-Position: refs/heads/master@{#19268}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bb992e71594e77f2c43a3bfad...
==========

[commit-bot: I haz the power, 2017-08-08 13:19:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bb992e71594e77f2c43a3bfad...