Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2968943002: Remove LoadSystemKeyboard() (Closed)

Created:
3 years, 5 months ago by Blake O(Apostrophe)Hare
Modified:
3 years, 5 months ago
Reviewers:
oka, yhanada
CC:
chromium-reviews, blakeo+virtualkb_chromium.org, jam, darin-cc_chromium.org, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LoadSystemKeyboard() BUG=737004 Review-Url: https://codereview.chromium.org/2968943002 Cr-Commit-Position: refs/heads/master@{#483960} Committed: https://chromium.googlesource.com/chromium/src/+/b183f257cc5f626345bec1e2b776113ac70ac063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M ui/keyboard/content/keyboard_ui_content.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/content/keyboard_ui_content.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Blake O(Apostrophe)Hare
3 years, 5 months ago (2017-07-03 06:56:18 UTC) #5
oka
lgtm
3 years, 5 months ago (2017-07-03 07:06:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968943002/1
3 years, 5 months ago (2017-07-03 07:36:48 UTC) #10
yhanada
lgtm. I thought we also can remove GetKeyboardRootWindow(), but it's used by the child class...
3 years, 5 months ago (2017-07-03 07:42:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/479422)
3 years, 5 months ago (2017-07-03 07:42:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968943002/1
3 years, 5 months ago (2017-07-03 07:46:39 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 08:02:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b183f257cc5f626345bec1e2b776...

Powered by Google App Engine
This is Rietveld 408576698