Fixed importing of empty folders from HTML bookmarks file

Fixed importing of empty folders from HTML bookmarks file

BUG=738912
Review-Url: https://codereview.chromium.org/2968923003
Cr-Commit-Position: refs/heads/master@{#484523}
Committed: https://chromium.googlesource.com/chromium/src/+/6cd2e2ecb2f25705691db6b37d272ec59aebc30e

[vitreb, 2017-07-03 15:23:22]

vitreb@yandex-team.ru changed reviewers:
+ gab@chromium.org

[vitreb, 2017-07-03 15:23:23]

https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
File chrome/utility/importer/bookmark_html_reader.cc (right):

https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
chrome/utility/importer/bookmark_html_reader.cc:212: if (!has_subfolder &&
has_last_folder) {
I used flag instead of checking for last_folder emptiness. It's possible to use
base::Optional for this but I decided to not change code style of this function.

[vitreb, 2017-07-04 08:22:32]

Description was changed from

==========
Fixed importing of empty folders from HTML bookmarks file

BUG=738912
==========

to

==========
Fixed importing of empty folders from HTML bookmarks file

BUG=738912
==========

[vitreb, 2017-07-04 08:22:32]

vitreb@yandex-team.ru changed reviewers:
+ isherman@chromium.org
- gab@chromium.org

[Ilya Sherman, 2017-07-05 18:00:31]

LGTM % nits, thanks.

https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
File chrome/utility/importer/bookmark_html_reader.cc (right):

https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
chrome/utility/importer/bookmark_html_reader.cc:213: has_last_folder = false;
nit: Please move this one or two lines down, to be adjacent with
last_folder.clear().

https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
chrome/utility/importer/bookmark_html_reader.cc:233: has_last_folder = false;
Ditto

[vitreb, 2017-07-06 08:47:00]

On 2017/07/05 18:00:31, Ilya Sherman wrote:
> LGTM % nits, thanks.
> 
>
https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
> File chrome/utility/importer/bookmark_html_reader.cc (right):
> 
>
https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
> chrome/utility/importer/bookmark_html_reader.cc:213: has_last_folder = false;
> nit: Please move this one or two lines down, to be adjacent with
> last_folder.clear().
> 
>
https://codereview.chromium.org/2968923003/diff/1/chrome/utility/importer/boo...
> chrome/utility/importer/bookmark_html_reader.cc:233: has_last_folder = false;
> Ditto

Ok. Fixed.

[vitreb, 2017-07-06 08:47:09]

The CQ bit was checked by vitreb@yandex-team.ru

[vitreb, 2017-07-06 08:47:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2968923003/#ps20001
(title: "Fixed review issues")

[commit-bot: I haz the power, 2017-07-06 08:47:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 10:02:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499330829811100,
"parent_rev": "47a96ecefe24e33eb962d70b1e8f70bb5845c6ed", "commit_rev":
"6cd2e2ecb2f25705691db6b37d272ec59aebc30e"}

[commit-bot: I haz the power, 2017-07-06 10:03:11]

Description was changed from

==========
Fixed importing of empty folders from HTML bookmarks file

BUG=738912
==========

to

==========
Fixed importing of empty folders from HTML bookmarks file

BUG=738912

Review-Url: https://codereview.chromium.org/2968923003
Cr-Commit-Position: refs/heads/master@{#484523}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cd2e2ecb2f25705691db6b37d27...
==========

[commit-bot: I haz the power, 2017-07-06 10:03:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cd2e2ecb2f25705691db6b37d27...