Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2968873002:
Prevent signin frame size update at first login (Closed)
|
Created:
3 years, 5 months ago by Wenzhao (Colin) Zang Modified:
3 years, 5 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrevent signin frame size update at first login
Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/,
which is because updateScreenSize() is called to make the size of the
inner container become zero when the account picker is shown.
BUG=738775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2968873002
Cr-Commit-Position: refs/heads/master@{#484414}
Committed: https://chromium.googlesource.com/chromium/src/+/c80cdf41b84020bcf6bef3ac4fe21f5d028522c8
Patch Set 1 #Patch Set 2 : Add current screen check #Messages
Total messages: 33 (26 generated)
Description was changed from ========== Prevent signin frame size update at first login BUG=NONE ========== to ========== Prevent signin frame size update at first login BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Prevent signin frame size update at first login BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
wzang@chromium.org changed reviewers: + alemate@chromium.org
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Prevent signin frame size update at first login BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero, when the account picker is shown. Removing this line won't affect anything. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
wzang@chromium.org changed reviewers: + jdufault@chromium.org
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero, when the account picker is shown. Removing this line won't affect anything. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything else. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen. updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything else. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything else. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm but wait for alemate@
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. Removing this line won't affect anything else. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wzang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jdufault@chromium.org Link to the patchset: https://codereview.chromium.org/2968873002/#ps20001 (title: "Add current screen check")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499299843268710,
"parent_rev": "1c31bab963517e213972295d65333f567c0fb690", "commit_rev":
"c80cdf41b84020bcf6bef3ac4fe21f5d028522c8"}
Message was sent while issue was closed.
Description was changed from ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent signin frame size update at first login Fixes misplaced sign-in screen caused by https://codereview.chromium.org/2947263002/, which is because updateScreenSize() is called to make the size of the inner container become zero when the account picker is shown. BUG=738775 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2968873002 Cr-Commit-Position: refs/heads/master@{#484414} Committed: https://chromium.googlesource.com/chromium/src/+/c80cdf41b84020bcf6bef3ac4fe2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c80cdf41b84020bcf6bef3ac4fe2... |
