Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2968783002: exo: Fix dragging regression (Closed)

Created:
3 years, 5 months ago by Dominik Laskowski
Modified:
3 years, 5 months ago
Reviewers:
Peng, reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Fix dragging regression Capture during dragging was being set on the host window rather than the root surface window, which would break input. BUG=739233 TEST=ARC windows can be dragged. Review-Url: https://codereview.chromium.org/2968783002 Cr-Commit-Position: refs/heads/master@{#484394} Committed: https://chromium.googlesource.com/chromium/src/+/1be3dfcf77bd193032dc9b24213d96dff421de77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
Dominik Laskowski
PTAL.
3 years, 5 months ago (2017-06-30 19:27:21 UTC) #2
reveman
+penghuang, will this work with MUS?
3 years, 5 months ago (2017-06-30 19:53:04 UTC) #4
Peng
On 2017/06/30 19:53:04, reveman wrote: > +penghuang, will this work with MUS? Could you please ...
3 years, 5 months ago (2017-06-30 23:20:58 UTC) #5
Dominik Laskowski
On 2017/06/30 23:20:58, Peng wrote: > Could you please explain why setting on the host ...
3 years, 5 months ago (2017-07-01 00:01:09 UTC) #6
Peng
On 2017/07/01 00:01:09, Dominik Laskowski wrote: > On 2017/06/30 23:20:58, Peng wrote: > > Could ...
3 years, 5 months ago (2017-07-01 00:08:20 UTC) #7
reveman
lgtm
3 years, 5 months ago (2017-07-05 21:41:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968783002/1
3 years, 5 months ago (2017-07-05 22:04:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-06 00:05:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968783002/1
3 years, 5 months ago (2017-07-06 00:09:33 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:16:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1be3dfcf77bd193032dc9b24213d...

Powered by Google App Engine
This is Rietveld 408576698