|
|
Chromium Code Reviews|
Created:
3 years, 5 months ago by Dominik Laskowski Modified:
3 years, 5 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionexo: Fix dragging regression
Capture during dragging was being set on the host window rather than the
root surface window, which would break input.
BUG=739233
TEST=ARC windows can be dragged.
Review-Url: https://codereview.chromium.org/2968783002
Cr-Commit-Position: refs/heads/master@{#484394}
Committed: https://chromium.googlesource.com/chromium/src/+/1be3dfcf77bd193032dc9b24213d96dff421de77
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
domlaskowski@chromium.org changed reviewers: + reveman@chromium.org
PTAL.
reveman@chromium.org changed reviewers: + penghuang@chromium.org
+penghuang, will this work with MUS?
On 2017/06/30 19:53:04, reveman wrote: > +penghuang, will this work with MUS? Could you please explain why setting on the host window doesn't work? The host window is a container window for a surface tree, and the window in surface may be removed in future.
On 2017/06/30 23:20:58, Peng wrote: > Could you please explain why setting on the host window doesn't work? The host > window is a > container window for a surface tree, and the window in surface may be removed in > future. The target surface for input events is determined via the surface window. Setting capture on the host window prevents events from being dispatched to the root surface.
On 2017/07/01 00:01:09, Dominik Laskowski wrote: > On 2017/06/30 23:20:58, Peng wrote: > > Could you please explain why setting on the host window doesn't work? The host > > window is a > > container window for a surface tree, and the window in surface may be removed > in > > future. > > The target surface for input events is determined via the surface window. > Setting capture on the host window prevents events from being dispatched to the > root surface. Thanks. Lgtm
Description was changed from ========== exo: Fix dragging regression Capture during dragging was being set on the host window rather than the root surface window, which would break input. BUG=None TEST=ARC windows can be dragged. ========== to ========== exo: Fix dragging regression Capture during dragging was being set on the host window rather than the root surface window, which would break input. BUG=739233 TEST=ARC windows can be dragged. ==========
lgtm
The CQ bit was checked by domlaskowski@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by domlaskowski@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499299712914970, "parent_rev":
"be136d26331ef108304a4691c9144626b9e50313", "commit_rev":
"473dea0be407bb80c5271365483138be16804346"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499299712914970, "parent_rev":
"9805c860a67407267ff9c3517c29aacf2238a014", "commit_rev":
"cff819c1142fce18d6ce3b59c8a8acc72ff93fdb"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499299712914970, "parent_rev":
"2327ca13c5f346e1f03bfe7bf17cb17728316052", "commit_rev":
"1be3dfcf77bd193032dc9b24213d96dff421de77"}
Message was sent while issue was closed.
Description was changed from ========== exo: Fix dragging regression Capture during dragging was being set on the host window rather than the root surface window, which would break input. BUG=739233 TEST=ARC windows can be dragged. ========== to ========== exo: Fix dragging regression Capture during dragging was being set on the host window rather than the root surface window, which would break input. BUG=739233 TEST=ARC windows can be dragged. Review-Url: https://codereview.chromium.org/2968783002 Cr-Commit-Position: refs/heads/master@{#484394} Committed: https://chromium.googlesource.com/chromium/src/+/1be3dfcf77bd193032dc9b24213d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1be3dfcf77bd193032dc9b24213d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
