pkg/compiler/lib/src/ssa/builder.dart - Issue 2968743002: Use .callMethod instead of LocalFunctionElement as key in inference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2968743002: Use .callMethod instead of LocalFunctionElement as key in inference (Closed)

Patch Set: Updated cf. comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index becdaa3327037076712fb53aab1ed350720e8077..ff49942f217fafc05b58505b801a8c4e9734ec5c 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -706,8 +706,8 @@ class SsaAstGraphBuilder extends ast.Visitor

HGraph buildMethod(MethodElement functionElement) {

assert(functionElement.isImplementation, failedAt(functionElement));

- graph.calledInLoop =

- closedWorld.isCalledInLoop(functionElement.declaration);

+ MethodElement declaration = functionElement.declaration;

+ graph.calledInLoop = closedWorld.isCalledInLoop(declaration);

ast.FunctionExpression function = resolvedAst.node;

assert(function != null);

assert(elements.getFunctionDefinition(function) != null);