Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/compiler/lib/src/inferrer/type_system.dart

Issue 2968743002: Use .callMethod instead of LocalFunctionElement as key in inference (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/type_system.dart
diff --git a/pkg/compiler/lib/src/inferrer/type_system.dart b/pkg/compiler/lib/src/inferrer/type_system.dart
index 14703c1350f02ec762c726136467e61454f2c683..a1f4ed9a9b2e6fb5e970808d17efb330e6757bc1 100644
--- a/pkg/compiler/lib/src/inferrer/type_system.dart
+++ b/pkg/compiler/lib/src/inferrer/type_system.dart
@@ -331,14 +331,9 @@ class TypeSystem {
}
@deprecated
- ElementTypeInformation getInferredTypeOfLocalFunction(
- LocalFunctionElement element) {
- return _getInferredTypeOf(element);
- }
-
- @deprecated
ElementTypeInformation _getInferredTypeOf(Element element) {
element = element.implementation;
+ assert(element.isParameter || element is MemberElement);
return typeInformations[element] ??=
new ElementTypeInformation(element, this);
}
@@ -353,18 +348,9 @@ class TypeSystem {
});
}
- String getInferredSignatureOfLocalFunction(LocalFunctionElement function) {
- return _getInferredSignatureOf(
- getInferredTypeOfLocalFunction(function), function);
- }
-
String getInferredSignatureOfMethod(MethodElement function) {
- return _getInferredSignatureOf(getInferredTypeOfMember(function), function);
- }
-
- String _getInferredSignatureOf(
- ElementTypeInformation info, FunctionElement function) {
- FunctionElement impl = function.implementation;
+ ElementTypeInformation info = getInferredTypeOfMember(function);
+ MethodElement impl = function.implementation;
FunctionSignature signature = impl.functionSignature;
var res = "";
signature.forEachParameter((Element parameter) {
@@ -424,20 +410,10 @@ class TypeSystem {
new ListTypeInformation(currentMember, mask, element, length);
}
- /// Creates a [TypeInformation] object for the local function [element] of
- /// a function expression or local function declaration used as a closure.
- TypeInformation allocateClosureForLocalFunction(
- ast.Node node, LocalFunctionElement element) {
- TypeInformation result =
- new LocalFunctionClosureTypeInformation(currentMember, node, element);
- allocatedClosures.add(result);
- return result;
- }
-
- /// Creates a [TypeInformation] object for the closurization of a static or
- /// top-level method [element] used a function constant.
- TypeInformation allocateClosureForMethod(
- ast.Node node, MethodElement element) {
+ /// Creates a [TypeInformation] object either for the closurization of a
+ /// static or top-level method [element] used as a function constant or for
+ /// the synthesized 'call' method [element] created for a local function.
+ TypeInformation allocateClosure(ast.Node node, MethodElement element) {
TypeInformation result =
new ClosureTypeInformation(currentMember, node, element);
allocatedClosures.add(result);
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698