Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2968723003: Fix net-export file path that is used on desktop. (Closed)

Created:
3 years, 5 months ago by eroman
Modified:
3 years, 5 months ago
Reviewers:
xunjieli
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net-export file path that is used on desktop. This bug was introduced by 30355da69277622a7f6bb2129c0435b1e1223f49. BUG=711432 Review-Url: https://codereview.chromium.org/2968723003 Cr-Commit-Position: refs/heads/master@{#483817} Committed: https://chromium.googlesource.com/chromium/src/+/144002e61ba9773f3375290854e4dcaee320a218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/net_export_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
eroman
3 years, 5 months ago (2017-06-30 19:46:44 UTC) #3
xunjieli
lgtm
3 years, 5 months ago (2017-06-30 19:47:27 UTC) #5
eroman
I am thinking about how to add a regression test for this -- probably we ...
3 years, 5 months ago (2017-06-30 19:48:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968723003/1
3 years, 5 months ago (2017-06-30 19:49:17 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:19:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/144002e61ba9773f3375290854e4...

Powered by Google App Engine
This is Rietveld 408576698