Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2968723002: Prerender: Add timeout to appcache waiting in NoStatePrefetch browser test. (Closed)

Created:
3 years, 5 months ago by mattcary
Modified:
3 years, 5 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: Add timeout to appcache waiting in NoStatePrefetch browser test. This may fix flakiness in this test. I have not been able to reproduce the flakes locally, so I'll have to observe the dashboard and see if this eliminates the occasional timeout. BUG=733504 Review-Url: https://codereview.chromium.org/2968723002 Cr-Commit-Position: refs/heads/master@{#483979} Committed: https://chromium.googlesource.com/chromium/src/+/3b32efaba81015f0f4aae00726bbcdeb0623bb9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mattcary
3 years, 5 months ago (2017-06-30 14:56:38 UTC) #2
Benoit L
On 2017/06/30 14:56:38, mattcary wrote: lgtm
3 years, 5 months ago (2017-07-03 08:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968723002/1
3 years, 5 months ago (2017-07-03 09:41:20 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 10:22:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b32efaba81015f0f4aae00726bb...

Powered by Google App Engine
This is Rietveld 408576698