Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4080)

Unified Diff: chrome/browser/ui/views/harmony/harmony_layout_provider.cc

Issue 2968713003: Harmonize the find in page dialog. (Closed)
Patch Set: Added distance metrics for toast button/label/text. Using these in the find bar. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/harmony_layout_provider.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_provider.cc b/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
index 29d289bb27dadc3d8a0abdfe127f059040f50a59..f87a869147baaa4f4f9b3d074b5c19e8a7368fa8 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
@@ -71,6 +71,12 @@ int HarmonyLayoutProvider::GetDistanceMetric(int metric) const {
return kHarmonyLayoutUnit;
case DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE:
return kHarmonyLayoutUnit;
+ case DISTANCE_TOAST_BUTTON_VERTICAL:
Peter Kasting 2017/07/13 04:52:47 I don't think you need to override any of these, s
ananta 2017/07/13 05:22:11 Not doing this caused the NOTREACHED() in the func
Peter Kasting 2017/07/13 05:31:37 Hmm. I'd say, remove the NOTREACHED and return 0,
ananta 2017/07/13 05:43:49 Thanks. Done
+ return kHarmonyLayoutUnit / 2;
+ case DISTANCE_TOAST_TEXT_VERTICAL:
+ return kHarmonyLayoutUnit / 2 ;
+ case DISTANCE_TOAST_LABEL_VERTICAL:
+ return 12;
}
NOTREACHED();
return 0;

Powered by Google App Engine
This is Rietveld 408576698