Harmonize the find in page dialog.

chrome/browser/ui/views/harmony/harmony_layout_provider.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/harmony/harmony_layout_provider.h"
 
 gfx::Insets HarmonyLayoutProvider::GetInsetsMetric(int metric) const {
   DCHECK_LT(metric, views::VIEWS_INSETS_MAX);
   switch (metric) {
     case views::INSETS_BUBBLE_CONTENTS:
@@ skipping 53 matching lines @@
     case DISTANCE_SUBSECTION_HORIZONTAL_INDENT:
       return 0;
     case DISTANCE_UNRELATED_CONTROL_HORIZONTAL:
       return kHarmonyLayoutUnit;
     case DISTANCE_UNRELATED_CONTROL_HORIZONTAL_LARGE:
       return kHarmonyLayoutUnit;
     case views::DISTANCE_UNRELATED_CONTROL_VERTICAL:
       return kHarmonyLayoutUnit;
     case DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE:
       return kHarmonyLayoutUnit;
+    case DISTANCE_TOAST_BUTTON_VERTICAL:

[Peter Kasting, 2017/07/13 04:52:47]

I don't think you need to override any of these, since they all match your base
values.

[ananta, 2017/07/13 05:22:11]

Not doing this caused the NOTREACHED() in the function to fire for harmony

[Peter Kasting, 2017/07/13 05:31:37]

Hmm.  I'd say, remove the NOTREACHED and return 0, and instead add a default
case to the loop that calls the ChromeLayoutProvider, as we did with the insets
function above.

[ananta, 2017/07/13 05:43:49]

Thanks. Done

+      return kHarmonyLayoutUnit / 2;
+    case DISTANCE_TOAST_TEXT_VERTICAL:
+      return kHarmonyLayoutUnit / 2 ;
+    case DISTANCE_TOAST_LABEL_VERTICAL:
+      return 12;
   }
   NOTREACHED();
   return 0;
 }
 
 views::GridLayout::Alignment
 HarmonyLayoutProvider::GetControlLabelGridAlignment() const {
   return views::GridLayout::LEADING;
 }
 
@@ skipping 16 matching lines @@
   }
 
   return ((min_width + kHarmonyLayoutUnit - 1) / kHarmonyLayoutUnit) *
          kHarmonyLayoutUnit;
 }
 
 const views::TypographyProvider& HarmonyLayoutProvider::GetTypographyProvider()
     const {
   return typography_provider_;
 }