Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4400)

Unified Diff: chrome/browser/ui/views/harmony/chrome_layout_provider.h

Issue 2968713003: Harmonize the find in page dialog. (Closed)
Patch Set: format fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/chrome_layout_provider.h
diff --git a/chrome/browser/ui/views/harmony/chrome_layout_provider.h b/chrome/browser/ui/views/harmony/chrome_layout_provider.h
index f647d06b103fecca4c797d4b913f3cf21e691f17..2c64b5cc44b7d1ab4260101cf86d9f460042e6cc 100644
--- a/chrome/browser/ui/views/harmony/chrome_layout_provider.h
+++ b/chrome/browser/ui/views/harmony/chrome_layout_provider.h
@@ -31,6 +31,10 @@ enum ChromeDistanceMetric {
// Horizontal indent of a subsection relative to related items above, e.g.
// checkboxes below explanatory text/headings.
DISTANCE_SUBSECTION_HORIZONTAL_INDENT,
+ // Vertical margin for controls in a toast.
+ DISTANCE_TOAST_CONTROL_VERTICAL,
+ // Vertical margin for labels in a toast.
+ DISTANCE_TOAST_LABEL_VERTICAL,
// Horizontal spacing between controls that are logically unrelated.
DISTANCE_UNRELATED_CONTROL_HORIZONTAL,
// Larger horizontal spacing between unrelated controls.
@@ -39,6 +43,11 @@ enum ChromeDistanceMetric {
DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE,
};
+enum InsetsMetric {
Peter Kasting 2017/07/15 07:38:36 This has to be ChromeInsetsMetric, or you have a n
ananta 2017/07/17 19:11:04 Done.
+ // Margins used by toasts.
+ INSETS_TOAST = views::VIEWS_INSETS_END,
+};
+
class ChromeLayoutProvider : public views::LayoutProvider {
public:
ChromeLayoutProvider() {}
@@ -50,6 +59,7 @@ class ChromeLayoutProvider : public views::LayoutProvider {
// views::LayoutProvider:
int GetDistanceMetric(int metric) const override;
const views::TypographyProvider& GetTypographyProvider() const override;
+ gfx::Insets GetInsetsMetric(int metric) const override;
Peter Kasting 2017/07/15 07:38:36 Nit: Please match the base class order
ananta 2017/07/17 19:11:04 Done.
// Returns the alignment used for control labels in a GridLayout; for example,
// in this GridLayout:

Powered by Google App Engine
This is Rietveld 408576698