Harmonize the find in page dialog.

chrome/browser/ui/views/harmony/chrome_layout_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 13 matching lines @@
   DISTANCE_RELATED_CONTROL_VERTICAL_SMALL,
   // Horizontal spacing between an item such as an icon or checkbox and a
   // label related to it.
   DISTANCE_RELATED_LABEL_HORIZONTAL,
   // Horizontal spacing between an item and the related label, in the context of
   // a row of such items. E.g. the bookmarks bar.
   DISTANCE_RELATED_LABEL_HORIZONTAL_LIST,
   // Horizontal indent of a subsection relative to related items above, e.g.
   // checkboxes below explanatory text/headings.
   DISTANCE_SUBSECTION_HORIZONTAL_INDENT,
+  // Vertical margin for controls in a toast.
+  DISTANCE_TOAST_CONTROL_VERTICAL,
+  // Vertical margin for labels in a toast.
+  DISTANCE_TOAST_LABEL_VERTICAL,
   // Horizontal spacing between controls that are logically unrelated.
   DISTANCE_UNRELATED_CONTROL_HORIZONTAL,
   // Larger horizontal spacing between unrelated controls.
   DISTANCE_UNRELATED_CONTROL_HORIZONTAL_LARGE,
   // Larger vertical spacing between unrelated controls.
   DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE,
 };
 
+enum InsetsMetric {

[Peter Kasting, 2017/07/15 07:38:36]

This has to be ChromeInsetsMetric, or you have a name conflict.

Nit: This should go above ChromeDistanceMetric to match the base class order

[ananta, 2017/07/17 19:11:04]

Done.

+  // Margins used by toasts.
+  INSETS_TOAST = views::VIEWS_INSETS_END,
+};
+
 class ChromeLayoutProvider : public views::LayoutProvider {
  public:
   ChromeLayoutProvider() {}
   ~ChromeLayoutProvider() override {}
 
   static ChromeLayoutProvider* Get();
   static std::unique_ptr<views::LayoutProvider> CreateLayoutProvider();
 
   // views::LayoutProvider:
   int GetDistanceMetric(int metric) const override;
   const views::TypographyProvider& GetTypographyProvider() const override;
+  gfx::Insets GetInsetsMetric(int metric) const override;

[Peter Kasting, 2017/07/15 07:38:36]

Nit: Please match the base class order

[ananta, 2017/07/17 19:11:04]

Done.

 
   // Returns the alignment used for control labels in a GridLayout; for example,
   // in this GridLayout:
   //   ---------------------------
   //   | Label 1      Checkbox 1 |
   //   | Label 2      Checkbox 2 |
   //   ---------------------------
   // This value controls the alignment used for "Label 1" and "Label 2".
   virtual views::GridLayout::Alignment GetControlLabelGridAlignment() const;
 
@@ skipping 10 matching lines @@
   // types, e.g. by adding a new LayoutDistance value that means what you need.
   //
   // TODO(pkasting): Fix callers and remove this.
   virtual bool IsHarmonyMode() const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_