Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2968713002: Remove all uses of LOG_DISABLED in blink (Closed)

Created:
3 years, 5 months ago by gyuyoung
Modified:
3 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all uses of LOG_DISABLED in blink As a step to reduce uses of Assertions.h, this CL removes all uses of LOG_DISABLED. Instead we use DCHECK_IS_ON() directly. BUG=596760 Review-Url: https://codereview.chromium.org/2968713002 Cr-Commit-Position: refs/heads/master@{#483933} Committed: https://chromium.googlesource.com/chromium/src/+/d220b6100bd95c09d95e9d4bd8b6edb52f1b8a3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/Assertions.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/Assertions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
gyuyoung
tkent, this is a new cleanup patch. PTAL.
3 years, 5 months ago (2017-06-30 14:20:12 UTC) #2
tkent
lgtm
3 years, 5 months ago (2017-07-03 00:02:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968713002/1
3 years, 5 months ago (2017-07-03 00:02:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/250106)
3 years, 5 months ago (2017-07-03 00:21:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968713002/1
3 years, 5 months ago (2017-07-03 03:11:57 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 03:50:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d220b6100bd95c09d95e9d4bd8b6...

Powered by Google App Engine
This is Rietveld 408576698