Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2968643002: Update minimum space for migration to 50MB (Closed)

Created:
3 years, 5 months ago by dspaid
Modified:
3 years, 5 months ago
Reviewers:
hidehiko, fukino
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update minimum space for migration to 50MB Users with large numbers of directories may require more space overhead as any given directory tree may be duplicated on both source and destination. Increase the minimum migration storage space to account for this. BUG=737343 TEST=Fill disk and attempt to migrate Review-Url: https://codereview.chromium.org/2968643002 Cr-Commit-Position: refs/heads/master@{#483940} Committed: https://chromium.googlesource.com/chromium/src/+/55067bd6ae2557dd1ca2ef1dcf796fe7d2175456

Patch Set 1 #

Patch Set 2 : Update minimum space for migration to 50MB #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/arc/arc_migration_constants.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dspaid
PTAL I verified that we do insert this constant into the UI strings in encryption_migration_screen_handler.cc:475
3 years, 5 months ago (2017-06-30 07:06:24 UTC) #2
fukino
lgtm. Thanks!
3 years, 5 months ago (2017-06-30 07:17:18 UTC) #3
dspaid
+hidehiko@ for OWNERS
3 years, 5 months ago (2017-07-03 00:37:19 UTC) #5
hidehiko
lgtm
3 years, 5 months ago (2017-07-03 02:32:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968643002/20001
3 years, 5 months ago (2017-07-03 04:04:31 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 04:34:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55067bd6ae2557dd1ca2ef1dcf79...

Powered by Google App Engine
This is Rietveld 408576698