Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2968613002: Move some of c/b/feedback/system_logs to //components/feedback (Closed)

Created:
3 years, 5 months ago by michaelpg
Modified:
3 years, 5 months ago
Reviewers:
afakhry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some of c/b/feedback/system_logs to //components/feedback BUG=710168 Review-Url: https://codereview.chromium.org/2968613002 Cr-Commit-Position: refs/heads/master@{#487265} Committed: https://chromium.googlesource.com/chromium/src/+/5d600d42d1f75df892ac447293e9c40a8707adef

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -272 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system_logs/command_line_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/dbus_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_daemon_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/device_event_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/lsb_release_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/single_log_file_log_source.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/log_source_access_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/log_source_resource.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/single_log_source_factory.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/chrome_system_logs_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/crash_ids_source.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/feedback/system_logs/system_logs_fetcher.h View 1 2 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/feedback/system_logs/system_logs_fetcher.cc View 1 2 3 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/feedback/system_logs/system_logs_source.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/feedback/system_logs/system_logs_source.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/system_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/feedback/system_logs/system_logs_fetcher.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + components/feedback/system_logs/system_logs_fetcher.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
A + components/feedback/system_logs/system_logs_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/feedback/system_logs/system_logs_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
michaelpg
PTAL.
3 years, 5 months ago (2017-06-29 23:28:13 UTC) #2
michaelpg
rebase
3 years, 5 months ago (2017-06-30 16:46:03 UTC) #3
afakhry
lgtm
3 years, 5 months ago (2017-07-01 00:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968613002/40001
3 years, 5 months ago (2017-07-06 20:11:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/214644)
3 years, 5 months ago (2017-07-06 20:41:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968613002/80001
3 years, 5 months ago (2017-07-14 02:41:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/428876)
3 years, 5 months ago (2017-07-14 03:09:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968613002/100001
3 years, 5 months ago (2017-07-17 19:39:14 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 22:04:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5d600d42d1f75df892ac447293e9...

Powered by Google App Engine
This is Rietveld 408576698