Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 296853009: Reduce potential flakiness of SimpleGeolocationTest. (Closed)

Created:
6 years, 7 months ago by Alexander Alekseev
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reduce potential flakiness of SimpleGeolocationTest. SimpleGeolocation unittest should less depend on timings. BUG=245075 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc View 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Alekseev
6 years, 7 months ago (2014-05-22 17:53:22 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-23 15:12:47 UTC) #2
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-05-23 15:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/296853009/1
6 years, 7 months ago (2014-05-23 15:13:17 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 18:31:34 UTC) #5
Message was sent while issue was closed.
Change committed as 272566

Powered by Google App Engine
This is Rietveld 408576698