Reduce potential flakiness of SimpleGeolocationTest.

chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "chrome/browser/chromeos/geolocation/simple_geolocation_provider.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/test_url_fetcher_factory.h"
@@ skipping 198 matching lines @@
 
 TEST_F(SimpleGeolocationTest, InvalidResponse) {
   SimpleGeolocationProvider provider(NULL, GURL(kTestGeolocationProviderUrl));
 
   GeolocationAPIFetcherFactory url_factory(GURL(kTestGeolocationProviderUrl),
                                            "invalid JSON string",
                                            0 /* require_retries */,
                                            &provider);
 
   GeolocationReceiver receiver;
+
   const int timeout_seconds = 1;
+  size_t expected_retries = static_cast<size_t>(
+      timeout_seconds * 1000 / kRequestRetryIntervalMilliSeconds);
+  ASSERT_GE(expected_retries, 2U);
+
   provider.RequestGeolocation(base::TimeDelta::FromSeconds(timeout_seconds),
                               base::Bind(&GeolocationReceiver::OnRequestDone,
                                          base::Unretained(&receiver)));
   receiver.WaitUntilRequestDone();
 
   EXPECT_EQ(
       "latitude=200.000000, longitude=200.000000, accuracy=-1.000000, "
       "error_code=0, error_message='SimpleGeolocation provider at "
       "'https://localhost/' : JSONReader failed: Line: 1, column: 1, "
       "Unexpected token..', status=4 (TIMEOUT)",
       receiver.position().ToString());
   EXPECT_TRUE(receiver.server_error());
-  size_t expected_retries = static_cast<size_t>(
-      timeout_seconds * 1000 / kRequestRetryIntervalMilliSeconds);
-  EXPECT_LE(url_factory.attempts(), expected_retries + 1);
-  EXPECT_GE(url_factory.attempts(), expected_retries - 1);
+  EXPECT_GE(url_factory.attempts(), 2U);
+  if (url_factory.attempts() > expected_retries + 1) {
+    LOG(WARNING)
+        << "SimpleGeolocationTest::InvalidResponse: Too many attempts ("
+        << url_factory.attempts() << "), no more then " << expected_retries + 1
+        << " expected.";
+  }
+  if (url_factory.attempts() < expected_retries - 1) {
+    LOG(WARNING)
+        << "SimpleGeolocationTest::InvalidResponse: Too little attempts ("
+        << url_factory.attempts() << "), greater then " << expected_retries - 1
+        << " expected.";
+  }
 }
 
 }  // namespace chromeos