Issue 2968403002: Remove the --build-summary-only-diet option.

Issue 2968403002: Remove the --build-summary-only-diet option. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove the --build-summary-only-diet option. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/711e37295afde12d55ace7c724df0388a7b0c2c7

Patch Set 1 #

Total comments: 1

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -50 lines)			Patch
M	pkg/analyzer_cli/lib/src/build_mode.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/driver.dart	View	5 chunks	+13 lines, -15 lines	1 comment	Download
M	pkg/analyzer_cli/lib/src/options.dart	View	4 chunks	+0 lines, -15 lines	0 comments	Download
M	pkg/analyzer_cli/test/options_test.dart	View	2 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2968403002/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2968403002/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode135 pkg/analyzer_cli/lib/src/driver.dart:135: // TODO(devoncarew): Replace with the real crash product ...

3 years, 5 months ago (2017-07-07 15:40:54 UTC) #3

scheglov

3 years, 5 months ago (2017-07-07 16:15:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
711e37295afde12d55ace7c724df0388a7b0c2c7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages