Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: pkg/analyzer_cli/lib/src/options.dart

Issue 2968403002: Remove the --build-summary-only-diet option. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_cli/lib/src/options.dart
diff --git a/pkg/analyzer_cli/lib/src/options.dart b/pkg/analyzer_cli/lib/src/options.dart
index 776828240cf171c94b40813914ff48ae33e20013..c7a64921da0119c2063846c82ce301e6e8cf9bdc 100644
--- a/pkg/analyzer_cli/lib/src/options.dart
+++ b/pkg/analyzer_cli/lib/src/options.dart
@@ -57,10 +57,6 @@ class CommandLineOptions {
/// Whether to skip analysis when creating summaries in build mode.
final bool buildSummaryOnly;
- /// Whether to use diet parsing, i.e. skip function bodies. We don't need to
- /// analyze function bodies to use summaries during future compilation steps.
- final bool buildSummaryOnlyDiet;
-
/// Whether to only produce unlinked summaries instead of linked summaries.
/// Must be used in combination with `buildSummaryOnly`.
final bool buildSummaryOnlyUnlinked;
@@ -167,7 +163,6 @@ class CommandLineOptions {
buildSummaryUnlinkedInputs =
args['build-summary-unlinked-input'] as List<String>,
buildSummaryOnly = args['build-summary-only'],
- buildSummaryOnlyDiet = args['build-summary-only-diet'],
buildSummaryOnlyUnlinked = args['build-summary-only-unlinked'],
buildSummaryOutput = args['build-summary-output'],
buildSummaryOutputSemantic = args['build-summary-output-semantic'],
@@ -281,11 +276,6 @@ class CommandLineOptions {
'together with --build-mode.');
return null; // Only reachable in testing.
}
- if (options.buildSummaryOnlyDiet && !options.buildSummaryOnly) {
- printAndFail('The option --build-summary-only-diet can be used only '
- 'together with --build-summary-only.');
- return null; // Only reachable in testing.
- }
if (options.buildSummaryOnlyUnlinked) {
if (!options.buildSummaryOnly) {
@@ -411,11 +401,6 @@ class CommandLineOptions {
defaultsTo: false,
negatable: false,
hide: hide)
- ..addFlag('build-summary-only-diet',
- help: 'Diet parse function bodies.',
- defaultsTo: false,
- negatable: false,
- hide: hide)
..addFlag('build-summary-only-unlinked',
help: 'Only output the unlinked summary.',
defaultsTo: false,

Powered by Google App Engine
This is Rietveld 408576698