Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2968343002: Fix gRPC error handling on Push. (Closed)

Created:
3 years, 5 months ago by aludwin
Modified:
3 years, 5 months ago
Reviewers:
ryanmartens, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix gRPC error handling on Push. Tested: generated an ALREADY_EXISTS exception on the proxy and verified that it's correctly ignored. BUG= Review-Url: https://codereview.chromium.org/2968343002 Committed: https://github.com/luci/luci-py/commit/9b6ac24b8798e83d363b6e492652bbeecf280128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M client/isolate_storage.py View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
aludwin
3 years, 5 months ago (2017-07-07 04:17:23 UTC) #2
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-07 17:55:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968343002/1
3 years, 5 months ago (2017-07-07 18:12:02 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 18:45:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/9b6ac24b8798e83d363b6e492652bbeecf280128

Powered by Google App Engine
This is Rietveld 408576698