Description was changed from ========== Notification test. ========== to ========== [EasyUnlock] Introduce EasyUnlockNotificationController This class ...
3 years, 5 months ago
(2017-07-07 00:12:36 UTC)
#1
Description was changed from
==========
Notification test.
==========
to
==========
[EasyUnlock] Introduce EasyUnlockNotificationController
This class is responsible for displaying and handling all EasyUnlock
notifications.
Originally, EasyUnlock notifications were shown by a component app, but this app
is now deprecated and we are migrating EasyUnlock natively for v2.
BUG=726791
==========
These assets are pretty old, but I'll sync up with UX to see if it's ...
3 years, 5 months ago
(2017-07-07 18:31:57 UTC)
#5
These assets are pretty old, but I'll sync up with UX to see if it's feasible to
vectorize this icon.
Is it okay to land this CL in case we can't get the assets from UX in time for
the branch point?
On 2017/07/07 18:31:57, Tim Song wrote: > These assets are pretty old, but I'll sync ...
3 years, 5 months ago
(2017-07-07 19:20:36 UTC)
#8
On 2017/07/07 18:31:57, Tim Song wrote:
> These assets are pretty old, but I'll sync up with UX to see if it's feasible
to
> vectorize this icon.
UX should be able to provide vector icons. Please let me know you you have any
trouble.
>
> Is it okay to land this CL in case we can't get the assets from UX in time for
> the branch point?
Branch point is 2 weeks from now, so you should be able to get them, but if you
couldn't yes.
Tim Song
https://codereview.chromium.org/2968323002/diff/20001/chrome/browser/signin/easy_unlock_notification_controller.cc File chrome/browser/signin/easy_unlock_notification_controller.cc (right): https://codereview.chromium.org/2968323002/diff/20001/chrome/browser/signin/easy_unlock_notification_controller.cc#newcode40 chrome/browser/signin/easy_unlock_notification_controller.cc:40: profile, message_center::MessageCenter::Get()); On 2017/07/07 18:36:58, Peter Beverloo wrote: > ...
3 years, 5 months ago
(2017-07-07 19:54:04 UTC)
#9
I added another notification for promoting EasyUnlock. Please take another look. https://codereview.chromium.org/2968323002/diff/40001/chrome/browser/signin/easy_unlock_notification_controller.h File chrome/browser/signin/easy_unlock_notification_controller.h (right): ...
3 years, 5 months ago
(2017-07-13 20:46:33 UTC)
#12
3 years, 5 months ago
(2017-07-17 19:53:44 UTC)
#13
lgtm++
Tim Song
Ping on this code review. We would like to get it in by branch point ...
3 years, 5 months ago
(2017-07-18 00:43:05 UTC)
#14
Ping on this code review. We would like to get it in by branch point :)
sacomoto
On 2017/07/18 00:43:05, Tim Song wrote: > Ping on this code review. We would like ...
3 years, 5 months ago
(2017-07-19 10:01:06 UTC)
#15
On 2017/07/18 00:43:05, Tim Song wrote:
> Ping on this code review. We would like to get it in by branch point :)
BTW, can you also add an notification controller interface in the proximity_auth
component?
oshima
On 2017/07/19 10:01:06, sacomoto wrote: > On 2017/07/18 00:43:05, Tim Song wrote: > > Ping ...
3 years, 5 months ago
(2017-07-20 18:21:56 UTC)
#16
On 2017/07/19 10:01:06, sacomoto wrote:
> On 2017/07/18 00:43:05, Tim Song wrote:
> > Ping on this code review. We would like to get it in by branch point :)
>
> BTW, can you also add an notification controller interface in the
proximity_auth
> component?
lgtm this time, but please ask UX to provide svg. We're switching to svg for
good reason,
and I really want to avoid adding another png files, even for short term
solution.
Tim Song
The CQ bit was checked by tengs@chromium.org
3 years, 5 months ago
(2017-07-20 18:35:29 UTC)
#17
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/475250)
3 years, 5 months ago
(2017-07-20 19:24:48 UTC)
#20
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500594199984430, "parent_rev": "56fdb075eb79bb939d3541bc70225fe8441f7a7a", "commit_rev": "321d5feb7b08e0e9b2b697de21438f10c7c004c3"}
3 years, 5 months ago
(2017-07-21 00:55:58 UTC)
#24
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500594199984430,
"parent_rev": "56fdb075eb79bb939d3541bc70225fe8441f7a7a", "commit_rev":
"321d5feb7b08e0e9b2b697de21438f10c7c004c3"}
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500594199984430, "parent_rev": "bfc6ec6735cf439c2971eb2129ae357e5b57e0de", "commit_rev": "b8c14e087eb455c3e712753d44eb8a2c62cba9f8"}
3 years, 5 months ago
(2017-07-21 00:56:18 UTC)
#25
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500594199984430,
"parent_rev": "bfc6ec6735cf439c2971eb2129ae357e5b57e0de", "commit_rev":
"b8c14e087eb455c3e712753d44eb8a2c62cba9f8"}
commit-bot: I haz the power
Description was changed from ========== [EasyUnlock] Introduce EasyUnlockNotificationController This class is responsible for displaying and ...
3 years, 5 months ago
(2017-07-21 00:56:37 UTC)
#26
Message was sent while issue was closed.
Description was changed from
==========
[EasyUnlock] Introduce EasyUnlockNotificationController
This class is responsible for displaying and handling all EasyUnlock
notifications.
Originally, EasyUnlock notifications were shown by a component app, but this app
is now deprecated and we are migrating EasyUnlock natively for v2.
BUG=726791
==========
to
==========
[EasyUnlock] Introduce EasyUnlockNotificationController
This class is responsible for displaying and handling all EasyUnlock
notifications.
Originally, EasyUnlock notifications were shown by a component app, but this app
is now deprecated and we are migrating EasyUnlock natively for v2.
BUG=726791
Review-Url: https://codereview.chromium.org/2968323002
Cr-Commit-Position: refs/heads/master@{#488522}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8c14e087eb455c3e712753d44eb...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/b8c14e087eb455c3e712753d44eb8a2c62cba9f8
3 years, 5 months ago
(2017-07-21 00:56:39 UTC)
#27
Issue 2968323002: [EasyUnlock] Introduce EasyUnlockNotificationController
(Closed)
Created 3 years, 5 months ago by Tim Song
Modified 3 years, 5 months ago
Reviewers: sacomoto, oshima, Peter Beverloo
Base URL:
Comments: 8