Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2968253002:
Remove ScopedVector. (Closed)
|
Created:
3 years, 5 months ago by Avi (use Gerrit) Modified:
3 years, 5 months ago Reviewers:
dcheng CC:
chromium-reviews, ios-reviews+chrome_chromium.org, sadrul, yusukes+watch_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, rogerm+autofillwatch_chromium.org, hidehiko+watch_chromium.org, browser-components-watch_chromium.org, gavinp+memory_chromium.org, marq+watch_chromium.org, lhchavez+watch_chromium.org, agrieve+watch_chromium.org, tracing+reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, lcwu+watch_chromium.org, jam, net-reviews_chromium.org, noyau+watch_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, feature-media-reviews_chromium.org, fuzzing_chromium.org, alokp+watch_chromium.org, gcasto+watchlist_chromium.org, elijahtaylor+arcwatch_chromium.org, Dirk Pranke, mathp+autofillwatch_chromium.org, wfh+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, victorhsieh+watch_chromium.org, tfarina, estade+watch_chromium.org, danakj+watch_chromium.org, sebsg+autofillwatch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector.
BUG=554289
Review-Url: https://codereview.chromium.org/2968253002
Cr-Commit-Position: refs/heads/master@{#485374}
Committed: https://chromium.googlesource.com/chromium/src/+/5ec22606f48aab799b7fec9a22d0b294cfbc0121
Patch Set 1 #Patch Set 2 : chromecast #Patch Set 3 : just the sv #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + dcheng@chromium.org
Daniel: for when everything else is removed
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
LGTM
:fireworks:
On 2017/07/07 17:54:06, danakj wrote: > :fireworks: Thanks! I only need https://codereview.chromium.org/2972053003 and https://codereview.chromium.org/2972773004 to land first. Alas, ppapi owners are out or in Australia, and the IPC fuzzer is complicated, so I'm targeting next week. Still, there will be a celebratory email sent.
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by avi@chromium.org
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499715598830680,
"parent_rev": "dc4e7f524afa9d60d6996ab76a6b84b66951ede0", "commit_rev":
"5ec22606f48aab799b7fec9a22d0b294cfbc0121"}
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector. BUG=554289 ========== to ========== Remove ScopedVector. BUG=554289 Review-Url: https://codereview.chromium.org/2968253002 Cr-Commit-Position: refs/heads/master@{#485374} Committed: https://chromium.googlesource.com/chromium/src/+/5ec22606f48aab799b7fec9a22d0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5ec22606f48aab799b7fec9a22d0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
