Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 296823014: Revert "Do away with variable length memcpy to Set/Get registers in simulator" (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Revert "Do away with variable length memcpy to Set/Get registers in simulator" This reverts r21148, it broke tests in debug mode, e.g. mjsunit/regress/regress-observe-map-cache or mjsunit/debug-stepout-scope-part5. TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -310 lines) Patch
M src/arm64/simulator-arm64.h View 7 chunks +102 lines, -57 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 17 chunks +232 lines, -234 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
Committed patchset #1 manually as r21449 (tree was closed).
6 years, 7 months ago (2014-05-23 07:14:11 UTC) #1
Benedikt Meurer
6 years, 7 months ago (2014-05-23 07:14:28 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698