Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2968203003:
Photo Picker dialog: Flesh out the number roll string a bit. (Closed)
DescriptionPhoto Picker dialog: Flesh out the number roll string a bit.
BUG=656015
Review-Url: https://codereview.chromium.org/2968203003
Cr-Commit-Position: refs/heads/master@{#484742}
Committed: https://chromium.googlesource.com/chromium/src/+/d185f78b475340fc10f8a670f8322b6067274fd9
Patch Set 1 #
Total comments: 1
Patch Set 2 : Sync and rename variable #
Total comments: 1
Patch Set 3 : Address feedback from Theresa #
Total comments: 1
Messages
Total messages: 36 (22 generated)
Description was changed from ========== Photo Picker dialog: Flesh out the number roll string a bit. BUG=656015 ========== to ========== Photo Picker dialog: Flesh out the number roll string a bit. BUG=656015 ==========
finnur@chromium.org changed reviewers: + twellington@chromium.org
https://codereview.chromium.org/2968203003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/widget/NumberRollView.java (right): https://codereview.chromium.org/2968203003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/widget/NumberRollView.java:110: if (mContentDescriptionStringId != 0) { Let's rename mContentDescriptionStringId to something like mStringId to indicate that it's used for more than just the content description now.
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done, PTAL
The CQ bit was unchecked by finnur@chromium.org
The CQ bit was checked by finnur@chromium.org
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
The CQ bit was unchecked by finnur@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Sorry, meant to run gcl try but for some reason clicked the commit instead. :) PTAL
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2968203003/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/widget/NumberRollView.java (right): https://codereview.chromium.org/2968203003/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/widget/NumberRollView.java:89: public void setContentDescriptionString(int pluralStringId) { nit: setString() and update the param description.
Actually, I ran: gcl try noticed the "commit box (dry run)" was checked. Thought I had accidentally committed and panicked. Unchecked commit box Realized my mistake Checked it again Panicked again because now I'd actually checked commit :) Unchecked it ran gcl try again :) Phew :)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by finnur@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2968203003/#ps40001 (title: "Address feedback from Theresa")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
bauerb@chromium.org changed reviewers: + bauerb@chromium.org
lgtm https://codereview.chromium.org/2968203003/diff/40001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2968203003/diff/40001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:2689: <message name="IDS_ACCESSIBILITY_SELECTED_ITEMS" desc="Content description for a number indicating how many items are selected. [ICU Syntax]"> Nit: This string now isn't really used for accessibility anymore.
Thanks, Bernhard! As agreed: will check in now and address this nit tomorrow.
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499375598886590,
"parent_rev": "07fdd86df08359938f8216e22c354da3b33a7011", "commit_rev":
"d185f78b475340fc10f8a670f8322b6067274fd9"}
Message was sent while issue was closed.
Description was changed from ========== Photo Picker dialog: Flesh out the number roll string a bit. BUG=656015 ========== to ========== Photo Picker dialog: Flesh out the number roll string a bit. BUG=656015 Review-Url: https://codereview.chromium.org/2968203003 Cr-Commit-Position: refs/heads/master@{#484742} Committed: https://chromium.googlesource.com/chromium/src/+/d185f78b475340fc10f8a670f832... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d185f78b475340fc10f8a670f832... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
