Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2968183002: Avoid naming conflict for Cache and Response in cachestorage (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
horo
CC:
chromium-reviews, shalamov, mlamouri+watch-blink_chromium.org, timvolodine, hongchan, blink-reviews, wanming.lin, haraken, mfoltz+watch_chromium.org, Raymond Toy, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid naming conflict for Cache and Response in cachestorage There are multiple Cache types and Response types so when importing one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol locally to avoid such naming conflicts. Review-Url: https://codereview.chromium.org/2968183002 Cr-Commit-Position: refs/heads/master@{#485939} Committed: https://chromium.googlesource.com/chromium/src/+/88e247a6d78987bbccd494264be3c4fca5fa654b

Patch Set 1 #

Patch Set 2 : fetch triggers crbug.com/739340 #

Patch Set 3 : Trying to make the cachestorage exclusions unnecessary. #

Patch Set 4 : Drop all the jumbo testing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 15 chunks +38 lines, -30 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Daniel Bratell
horo, please take a look. I'm trying to prepare some code so that I don't ...
3 years, 5 months ago (2017-07-07 12:21:46 UTC) #13
horo
lgtm Sorry for the late response.
3 years, 5 months ago (2017-07-11 23:46:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968183002/60001
3 years, 5 months ago (2017-07-12 11:32:33 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/499150)
3 years, 5 months ago (2017-07-12 13:02:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968183002/60001
3 years, 5 months ago (2017-07-12 13:19:54 UTC) #22
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 14:00:13 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/88e247a6d78987bbccd494264be3...

Powered by Google App Engine
This is Rietveld 408576698