Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2968183002:
Avoid naming conflict for Cache and Response in cachestorage (Closed)
|
Created:
3 years, 5 months ago by Daniel Bratell Modified:
3 years, 5 months ago Reviewers:
horo CC:
chromium-reviews, shalamov, mlamouri+watch-blink_chromium.org, timvolodine, hongchan, blink-reviews, wanming.lin, haraken, mfoltz+watch_chromium.org, Raymond Toy, Mikhail Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid naming conflict for Cache and Response in cachestorage
There are multiple Cache types and Response types so when importing
one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol
locally to avoid such naming conflicts.
Review-Url: https://codereview.chromium.org/2968183002
Cr-Commit-Position: refs/heads/master@{#485939}
Committed: https://chromium.googlesource.com/chromium/src/+/88e247a6d78987bbccd494264be3c4fca5fa654b
Patch Set 1 #Patch Set 2 : fetch triggers crbug.com/739340 #Patch Set 3 : Trying to make the cachestorage exclusions unnecessary. #Patch Set 4 : Drop all the jumbo testing code #
Messages
Total messages: 25 (19 generated)
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Making the cachestorage jumbo exclusions unnecessary. BUG= ========== to ========== Avoid naming conflict for Cache and Response in cachestorage There are multiple Cache types and Response types so when importing one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol locally to avoid such naming conflicts. ==========
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bratell@opera.com changed reviewers: + horo@chromium.org
horo, please take a look. I'm trying to prepare some code so that I don't have to exclude it later when I commit jumbo (unity build, merged source files) support for third_party/WebKit/Source/modules
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm Sorry for the late response.
The CQ bit was checked by bratell@opera.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bratell@opera.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499865590020120,
"parent_rev": "38fdbcd12c8beb2afd4fdd0d6504c94b053c9c2b", "commit_rev":
"88e247a6d78987bbccd494264be3c4fca5fa654b"}
Message was sent while issue was closed.
Description was changed from ========== Avoid naming conflict for Cache and Response in cachestorage There are multiple Cache types and Response types so when importing one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol locally to avoid such naming conflicts. ========== to ========== Avoid naming conflict for Cache and Response in cachestorage There are multiple Cache types and Response types so when importing one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol locally to avoid such naming conflicts. Review-Url: https://codereview.chromium.org/2968183002 Cr-Commit-Position: refs/heads/master@{#485939} Committed: https://chromium.googlesource.com/chromium/src/+/88e247a6d78987bbccd494264be3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/88e247a6d78987bbccd494264be3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
