Photo Picker dialog: Don't add toolbar shadow when an image has been selected.

Photo Picker dialog: Don't add toolbar shadow when an image has been selected.

Seeing the shadow appear on selection looks broken.

BUG=656015
Review-Url: https://codereview.chromium.org/2968163003
Cr-Commit-Position: refs/heads/master@{#484665}
Committed: https://chromium.googlesource.com/chromium/src/+/2e09651fabb3702dfaf6fb51088108afe4a3663d

[Finnur, 2017-07-06 15:00:58]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[Finnur, 2017-07-06 15:00:59]

I'll send you a screenshot with and without to clarify.

[Theresa, 2017-07-06 15:34:18]

https://codereview.chromium.org/2968163003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
(left):

https://codereview.chromium.org/2968163003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java:388:
|| mToolbar.getSelectionDelegate().isSelectionEnabled();
We are removing this shadow entirely in M62, but for now the spec for the other
selectable list layout clients requires a shadow on selection.

[Finnur, 2017-07-06 16:18:50]

Updated. PTAL.

[Theresa, 2017-07-06 16:58:41]

lgtm

[Finnur, 2017-07-06 17:03:43]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2017-07-06 17:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2968163003/#ps60001
(title: "Sync to latest (no code change)")

[commit-bot: I haz the power, 2017-07-06 17:03:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 18:03:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499360623514630,
"parent_rev": "519814bd8b4235d2f1702ebdc306a16c5b03707f", "commit_rev":
"2e09651fabb3702dfaf6fb51088108afe4a3663d"}

[commit-bot: I haz the power, 2017-07-06 18:03:41]

Description was changed from

==========
Photo Picker dialog: Don't add toolbar shadow when an image has been selected.

Seeing the shadow appear on selection looks broken.

BUG=656015
==========

to

==========
Photo Picker dialog: Don't add toolbar shadow when an image has been selected.

Seeing the shadow appear on selection looks broken.

BUG=656015

Review-Url: https://codereview.chromium.org/2968163003
Cr-Commit-Position: refs/heads/master@{#484665}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e09651fabb3702dfaf6fb510881...
==========

[commit-bot: I haz the power, 2017-07-06 18:03:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2e09651fabb3702dfaf6fb510881...