Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: components/toolbar/BUILD.gn

Issue 2968143003: Toolbar: Report offline state through icon and verbose text. (Closed)
Patch Set: Fix typo in string description. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/toolbar/BUILD.gn
diff --git a/components/toolbar/BUILD.gn b/components/toolbar/BUILD.gn
index 94163637c2b524e11718ef6e49a19ac62cef49f6..6f2271d708502eeb2698cb724b24e7eb02b030cf 100644
--- a/components/toolbar/BUILD.gn
+++ b/components/toolbar/BUILD.gn
@@ -24,6 +24,7 @@ aggregate_vector_icons("toolbar_vector_icons") {
"https_valid.icon",
"https_valid_in_chip.1x.icon",
"https_valid_in_chip.icon",
+ "offline_pin.icon",
Peter Kasting 2017/07/07 01:21:55 You should likely add distinct 1x and 2x versions,
cjgrant 2017/07/07 15:08:00 My understanding of 1x is that they're hand-tuned
cjgrant 2017/07/07 17:25:47 After talking to Terry, I still think this should
"product.1x.icon",
"product.icon",
"star_active.icon",

Powered by Google App Engine
This is Rietveld 408576698