Toolbar: Report offline state through icon and verbose text.

components/toolbar/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/ui.gni")
 import("//device/vr/features/features.gni")
 import("//ui/vector_icons/vector_icons.gni")
 
 buildflag_header("build_features") {
   header = "features.h"
   flags = [ "ENABLE_VR=$enable_vr" ]
 }
 
 aggregate_vector_icons("toolbar_vector_icons") {
   icon_directory = "vector_icons"
 
   icons = [
     "http.1x.icon",
     "http.icon",
     "https_invalid.1x.icon",
     "https_invalid.icon",
     "https_valid.1x.icon",
     "https_valid.icon",
     "https_valid_in_chip.1x.icon",
     "https_valid_in_chip.icon",
+    "offline_pin.icon",

[Peter Kasting, 2017/07/07 01:21:55]

You should likely add distinct 1x and 2x versions, as we've done for these
others.

[cjgrant, 2017/07/07 15:08:00]

My understanding of 1x is that they're hand-tuned to render nicely onto a 16x16
canvas, if the icon has features that warrant it.  As of now, there's no
foreseeable need for a 1x icon, as only VR uses it.  I've messaged Terry
Anderson offline about this - he mentioned adding a mechanism for catching
misuse of non-1x icons, I believe.

[cjgrant, 2017/07/07 17:25:47]

After talking to Terry, I still think this should be okay. The icon is usable at
any resolution, and a 1x icon could be introduced if required later.  However,
the check Terry mentioned is different - it ensures that a 1x icon isn't
rendered at another size (not applicable here).

     "product.1x.icon",
     "product.icon",
     "star_active.icon",
     "star.icon",
   ]
 }
 
 static_library("vector_icons") {
   sources = get_target_outputs(":toolbar_vector_icons")
   deps = [
@@ skipping 52 matching lines @@
   deps = [
     "//components/resources",
     "//ui/gfx",
   ]
 
   if (toolkit_views) {
     # Needed to get the TOOLKIT_VIEWS define.
     deps += [ "//ui/views" ]
   }
 }