Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2968133002: Revert of [Sync] Enable UserEvents by default. (Closed)

Created:
3 years, 5 months ago by lody
Modified:
3 years, 5 months ago
Reviewers:
skym, Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Enable UserEvents by default. (patchset #4 id:60001 of https://codereview.chromium.org/2956333002/ ) Reason for revert: Hello skym, unfortunately the answer to "Maybe iOS will work this time" was no :( It's breaking the downstream ios_chrome_ui_egtests . One such failure here: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/5603 Original issue's description: > [Sync] Enable UserEvents by default. > > Given we have approval to launching general EventLog machinery and each > actual EventLog use case (currently only translate) has their own > gating features, this seems reasonable to turn off by default. Leaving > the feature in the code such that we will have a kill switch if > anything goes wrong. > > BUG=701032 > > Review-Url: https://codereview.chromium.org/2956333002 > Cr-Commit-Position: refs/heads/master@{#484366} > Committed: https://chromium.googlesource.com/chromium/src/+/afe0f2c3cac407b2c28cf01f05d67a509418f5e7 TBR=pnoland@chromium.org,skym@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701032 Review-Url: https://codereview.chromium.org/2968133002 Cr-Commit-Position: refs/heads/master@{#484504} Committed: https://chromium.googlesource.com/chromium/src/+/87e7882837403c14362cf27e06e4d7302f7535cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/sync_driver_switches.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
lody
Created Revert of [Sync] Enable UserEvents by default.
3 years, 5 months ago (2017-07-06 08:55:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968133002/1
3 years, 5 months ago (2017-07-06 08:56:03 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 08:56:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87e7882837403c14362cf27e06e4...

Powered by Google App Engine
This is Rietveld 408576698