Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 296813002: Test orientation controller should update current orientation when it is not allowed by lock. (Closed)

Created:
6 years, 7 months ago by ostap
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Test orientation controller should update current orientation when it is not allowed by lock. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272020

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/screen_orientation/mock_screen_orientation_controller.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
ostap
6 years, 7 months ago (2014-05-20 18:18:26 UTC) #1
Inactive
https://codereview.chromium.org/296813002/diff/1/content/renderer/screen_orientation/mock_screen_orientation_controller.cc File content/renderer/screen_orientation/mock_screen_orientation_controller.cc (right): https://codereview.chromium.org/296813002/diff/1/content/renderer/screen_orientation/mock_screen_orientation_controller.cc#newcode34 content/renderer/screen_orientation/mock_screen_orientation_controller.cc:34: if (!IsOrientationAllowedByCurrentLock(current_orientation_)) Ah, my bad. I broke that in ...
6 years, 7 months ago (2014-05-20 18:20:20 UTC) #2
mlamouri (slow - plz ping)
On 2014/05/20 18:20:20, Chris Dumez wrote: > https://codereview.chromium.org/296813002/diff/1/content/renderer/screen_orientation/mock_screen_orientation_controller.cc > File content/renderer/screen_orientation/mock_screen_orientation_controller.cc > (right): > > ...
6 years, 7 months ago (2014-05-20 19:59:22 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-21 08:48:54 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-21 09:01:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/296813002/1
6 years, 7 months ago (2014-05-21 09:02:39 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 23:51:10 UTC) #7
Message was sent while issue was closed.
Change committed as 272020

Powered by Google App Engine
This is Rietveld 408576698