content/renderer/screen_orientation/mock_screen_orientation_controller.cc - Issue 296813002: Test orientation controller should update current orientation when it is not allowed by lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/mock_screen_orientation_controller.cc

Issue 296813002: Test orientation controller should update current orientation when it is not allowed by lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/screen_orientation/mock_screen_orientation_controller.cc

diff --git a/content/renderer/screen_orientation/mock_screen_orientation_controller.cc b/content/renderer/screen_orientation/mock_screen_orientation_controller.cc

index bc6f6c68a6ce36b7ded972550094d25a1e0e34a4..d16bc74e38d484a85ae12d069d94b877f7bbdace 100644

--- a/content/renderer/screen_orientation/mock_screen_orientation_controller.cc

+++ b/content/renderer/screen_orientation/mock_screen_orientation_controller.cc

@@ -31,7 +31,7 @@ void MockScreenOrientationController::UpdateLock(

blink::WebScreenOrientationLockType lock) {

DCHECK(lock != blink::WebScreenOrientationLockDefault);

current_lock_ = lock;

- if (IsOrientationAllowedByCurrentLock(current_orientation_))

+ if (!IsOrientationAllowedByCurrentLock(current_orientation_))

Inactive 2014/05/20 18:20:20 Ah, my bad. I broke that in when refactoring my CL

UpdateScreenOrientation(SuitableOrientationForCurrentLock());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »