Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)
Patch Set: address more comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index dca426ccd3a1fd2673450e51afff720d4220a7e6..3f7dd64792e4c55ec11cd23122dd1da46c18e7b8 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -108,8 +108,8 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
const GURL kScript("http://www.example.not/service_worker.js");
int64_t kRegistrationId = 1L;
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, kRegistrationId,
- context()->AsWeakPtr());
+ new ServiceWorkerRegistration(ServiceWorkerRegistrationOptions(kScope),
+ kRegistrationId, context()->AsWeakPtr());
const int64_t version_1_id = 1L;
const int64_t version_2_id = 2L;
@@ -175,8 +175,8 @@ TEST_F(ServiceWorkerRegistrationTest, FailedRegistrationNoCrash) {
const GURL kScope("http://www.example.not/");
int64_t kRegistrationId = 1L;
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, kRegistrationId,
- context()->AsWeakPtr());
+ new ServiceWorkerRegistration(ServiceWorkerRegistrationOptions(kScope),
+ kRegistrationId, context()->AsWeakPtr());
std::unique_ptr<ServiceWorkerRegistrationHandle> handle(
new ServiceWorkerRegistrationHandle(
context()->AsWeakPtr(), base::WeakPtr<ServiceWorkerProviderHost>(),
@@ -190,7 +190,8 @@ TEST_F(ServiceWorkerRegistrationTest, NavigationPreload) {
const GURL kScript("https://www.example.not/service_worker.js");
// Setup.
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, storage()->NewRegistrationId(),
+ new ServiceWorkerRegistration(ServiceWorkerRegistrationOptions(kScope),
+ storage()->NewRegistrationId(),
context()->AsWeakPtr());
scoped_refptr<ServiceWorkerVersion> version_1 = new ServiceWorkerVersion(
registration.get(), kScript, storage()->NewVersionId(),
@@ -234,7 +235,8 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {
const GURL kScript("https://www.example.not/service_worker.js");
registration_ = new ServiceWorkerRegistration(
- kScope, storage()->NewRegistrationId(), context()->AsWeakPtr());
+ ServiceWorkerRegistrationOptions(kScope),
+ storage()->NewRegistrationId(), context()->AsWeakPtr());
// Create an active version.
scoped_refptr<ServiceWorkerVersion> version_1 = new ServiceWorkerVersion(

Powered by Google App Engine
This is Rietveld 408576698