content/browser/service_worker/service_worker_storage.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: address more comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_storage.cc

diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc

index 7525da2236e4fb29d8c0ea83a32dd2bfb71d7dc9..8d38845d39f3c2464ae8a0f7398a21e9904e9ec3 100644

--- a/content/browser/service_worker/service_worker_storage.cc

+++ b/content/browser/service_worker/service_worker_storage.cc

@@ -1370,7 +1370,8 @@ ServiceWorkerStorage::GetOrCreateRegistration(

return registration;

registration = new ServiceWorkerRegistration(

- data.scope, data.registration_id, context_);

+ ServiceWorkerRegistrationOptions(data.scope), data.registration_id,

+ context_);

registration->set_resources_total_size_bytes(data.resources_total_size_bytes);

registration->set_last_update_check(data.last_update_check);

if (pending_deletions_.find(data.registration_id) !=