Chromium Code Reviews| Index: chrome/browser/ui/android/infobars/translate_infobar.cc |
| diff --git a/chrome/browser/ui/android/infobars/translate_infobar.cc b/chrome/browser/ui/android/infobars/translate_infobar.cc |
| index b49efe28f6204e1e77e39d550bb96b02679ea77d..dbd12c11ed0ff729d441cc78914f98854aa10beb 100644 |
| --- a/chrome/browser/ui/android/infobars/translate_infobar.cc |
| +++ b/chrome/browser/ui/android/infobars/translate_infobar.cc |
| @@ -18,6 +18,7 @@ |
| #include "chrome/browser/translate/chrome_translate_client.h" |
| #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h" |
| #include "components/translate/core/browser/translate_infobar_delegate.h" |
| +#include "components/translate/core/browser/translate_browser_metrics.h" |
|
napper
2017/07/06 05:09:01
sort
ramyasharma
2017/07/06 06:05:53
Done.
|
| #include "jni/TranslateInfoBar_jni.h" |
| using base::android::JavaParamRef; |
| @@ -28,13 +29,21 @@ using base::android::ScopedJavaLocalRef; |
| std::unique_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar( |
| std::unique_ptr<translate::TranslateInfoBarDelegate> delegate) const { |
| - if (base::FeatureList::IsEnabled(translate::kTranslateCompactUI)) |
| + if (base::FeatureList::IsEnabled(translate::kTranslateCompactUI)) { |
| + translate::TranslateBrowserMetrics::ReportInitiationStatus( |
| + translate::TranslateBrowserMetrics::INITIATION_STATUS_CREATE_INFOBAR); |
| return base::MakeUnique<TranslateCompactInfoBar>(std::move(delegate)); |
| - else |
| + } |
|
napper
2017/07/06 05:09:01
} else {
ramyasharma
2017/07/06 06:05:53
Done.
|
| + else { |
|
napper
2017/07/06 05:09:01
Note that the style guide says don't use else afte
ramyasharma
2017/07/06 06:05:53
Done.
|
| + if (delegate.get()->translate_step() == |
| + translate::TRANSLATE_STEP_BEFORE_TRANSLATE) { |
| + translate::TranslateBrowserMetrics::ReportInitiationStatus( |
| + translate::TranslateBrowserMetrics::INITIATION_STATUS_CREATE_INFOBAR); |
| + } |
| return base::MakeUnique<TranslateInfoBar>(std::move(delegate)); |
| + } |
| } |
| - |
| // TranslateInfoBar ----------------------------------------------------------- |
| TranslateInfoBar::TranslateInfoBar( |