Adds logging to indicate infobar creation in the native library,

chrome/browser/ui/android/infobars/translate_infobar.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/infobars/translate_infobar.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/jni_weak_ref.h"
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/translate/android/translate_utils.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h"
 #include "components/translate/core/browser/translate_infobar_delegate.h"
+#include "components/translate/core/browser/translate_browser_metrics.h"

[napper, 2017/07/06 05:09:01]

sort

[ramyasharma, 2017/07/06 06:05:53]

Done.

 #include "jni/TranslateInfoBar_jni.h"
 
 using base::android::JavaParamRef;
 using base::android::ScopedJavaLocalRef;
 
 // ChromeTranslateClient
 // ----------------------------------------------------------
 
 std::unique_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(
     std::unique_ptr<translate::TranslateInfoBarDelegate> delegate) const {
-  if (base::FeatureList::IsEnabled(translate::kTranslateCompactUI))
+  if (base::FeatureList::IsEnabled(translate::kTranslateCompactUI)) {
+    translate::TranslateBrowserMetrics::ReportInitiationStatus(
+      translate::TranslateBrowserMetrics::INITIATION_STATUS_CREATE_INFOBAR);
     return base::MakeUnique<TranslateCompactInfoBar>(std::move(delegate));
-  else
+  }

[napper, 2017/07/06 05:09:01]

} else {

[ramyasharma, 2017/07/06 06:05:53]

Done.

+  else {

[napper, 2017/07/06 05:09:01]

Note that the style guide says don't use else after return

[ramyasharma, 2017/07/06 06:05:53]

Done.

+    if (delegate.get()->translate_step() ==
+        translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
+      translate::TranslateBrowserMetrics::ReportInitiationStatus(
+          translate::TranslateBrowserMetrics::INITIATION_STATUS_CREATE_INFOBAR);
+    }
     return base::MakeUnique<TranslateInfoBar>(std::move(delegate));
+  }
 }
 
-
 // TranslateInfoBar -----------------------------------------------------------
 
 TranslateInfoBar::TranslateInfoBar(
     std::unique_ptr<translate::TranslateInfoBarDelegate> delegate)
     : InfoBarAndroid(std::move(delegate)) {}
 
 TranslateInfoBar::~TranslateInfoBar() {
 }
 
 ScopedJavaLocalRef<jobject> TranslateInfoBar::CreateRenderInfoBar(JNIEnv* env) {
@@ skipping 102 matching lines @@
 translate::TranslateInfoBarDelegate* TranslateInfoBar::GetDelegate() {
   return delegate()->AsTranslateInfoBarDelegate();
 }
 
 
 // Native JNI methods ---------------------------------------------------------
 
 bool RegisterTranslateInfoBarDelegate(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }