Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: pkg/analyzer/lib/src/summary/fasta/summary_builder.dart

Issue 2968093003: Improve parsing of function expressions. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/fasta/summary_builder.dart
diff --git a/pkg/analyzer/lib/src/summary/fasta/summary_builder.dart b/pkg/analyzer/lib/src/summary/fasta/summary_builder.dart
index 6425913c2dfb326d64cbc880578941205e5a9a29..42339ddc0616a90bcb85ee0efff49322d30f819e 100644
--- a/pkg/analyzer/lib/src/summary/fasta/summary_builder.dart
+++ b/pkg/analyzer/lib/src/summary/fasta/summary_builder.dart
@@ -218,8 +218,9 @@ abstract class ExpressionListener extends StackListener {
push(new StringLiteral(token.lexeme));
}
- void beginUnnamedFunction(token) {
- debugEvent("BeginUnnamedFunction");
+ @override
+ void beginFunctionExpression(token) {
+ debugEvent("beginFunctionExpression");
var check = pop();
assert(check == _invariantCheckToken);
_withinFunction++;
@@ -285,7 +286,7 @@ abstract class ExpressionListener extends StackListener {
assert(ignore);
}
- void endFunctionDeclaration(token) {
+ void endFunctionDeclaration(Token endToken) {
debugEvent("FunctionDeclaration");
_withinFunction--;
if (ignore) return;
@@ -370,8 +371,8 @@ abstract class ExpressionListener extends StackListener {
assert(ignore);
}
- void endUnnamedFunction(Token beginToken, Token token) {
- debugEvent("UnnamedFunction");
+ void endFunctionExpression(Token beginToken, Token token) {
danrubel 2017/07/06 15:43:34 @override ?
ahe 2017/07/06 19:54:18 Done.
+ debugEvent("FunctionExpression");
_withinFunction--;
if (ignore) return;
_endFunction();

Powered by Google App Engine
This is Rietveld 408576698