Improve parsing of function expressions.

pkg/analyzer/lib/src/summary/fasta/summary_builder.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Logic to build unlinked summaries.
 library summary.src.summary_builder;
 
 import 'package:front_end/src/fasta/parser.dart'
     show
         ClassMemberParser,
@@ skipping 200 matching lines @@
     debugEvent("BeginFunctionDeclaration");
     _withinFunction++;
   }
 
   void beginLiteralString(Token token) {
     debugEvent("beginLiteralString");
     if (ignore) return;
     push(new StringLiteral(token.lexeme));
   }
 
-  void beginUnnamedFunction(token) {
-    debugEvent("BeginUnnamedFunction");
+  @override
+  void beginFunctionExpression(token) {
+    debugEvent("beginFunctionExpression");
     var check = pop();
     assert(check == _invariantCheckToken);
     _withinFunction++;
   }
 
   UnlinkedExprBuilder computeExpression(Token token, Scope scope) {
     debugStart(token);
     parser.parseExpression(token);
     debugEvent('---- END ---');
     Expression node = pop();
@@ skipping 45 matching lines @@
       int count, Token beginToken, Token endToken, MemberKind kind) {
     debugEvent("FormalParameters");
     assert(ignore);
   }
 
   void endBlockFunctionBody(int count, Token begin, Token end) {
     debugEvent("BlockFunctionBody");
     assert(ignore);
   }
 
-  void endFunctionDeclaration(token) {
+  void endFunctionDeclaration(Token endToken) {
     debugEvent("FunctionDeclaration");
     _withinFunction--;
     if (ignore) return;
     _endFunction();
   }
 
   void endFunctionName(Token beginToken, Token token) {
     debugEvent("FunctionName");
     assert(ignore);
   }
@@ skipping 64 matching lines @@
   void endTypeVariable(Token token, Token extendsOrSuper) {
     debugEvent("endTypeVariable");
     assert(ignore);
   }
 
   void endTypeVariables(int count, Token beginToken, Token endToken) {
     debugEvent("TypeVariables");
     assert(ignore);
   }
 
-  void endUnnamedFunction(Token beginToken, Token token) {
-    debugEvent("UnnamedFunction");
+  void endFunctionExpression(Token beginToken, Token token) {

[danrubel, 2017/07/06 15:43:34]

@override ?

[ahe, 2017/07/06 19:54:18]

Done.

+    debugEvent("FunctionExpression");
     _withinFunction--;
     if (ignore) return;
     _endFunction();
   }
 
   void handleAsyncModifier(Token asyncToken, Token starToken) {
     debugEvent("AsyncModifier");
     assert(ignore);
   }
 
@@ skipping 1174 matching lines @@
 }
 
 /// Internal representation of an initialized name.
 class _InitializedName {
   final String name;
   final UnlinkedExecutableBuilder initializer;
   _InitializedName(this.name, this.initializer);
 
   toString() => "II:" + (initializer != null ? "$name = $initializer" : name);
 }