Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 2967973002: Select exact nodes in fast/text/selection-*.html (Closed)

Created:
3 years, 5 months ago by yoichio
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Select exact nodes in fast/text/selection-*.html Selection painting collapses last line breaks. This should be fixed. However, there are many layout tests which have expect.png of such painting even the tests confirm another issue. This CL makes such test independent from the painting behavior. BUG=739062 Review-Url: https://codereview.chromium.org/2967973002 Cr-Commit-Position: refs/heads/master@{#484184} Committed: https://chromium.googlesource.com/chromium/src/+/b30a6dddc14804ad52d22db845f119baf3ca6dd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/text/selection-painting-hidpi.html View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/selection-rect-line-height-too-big.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/selection-rect-line-height-too-small.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/selection-rect-rounding.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
yoichio
3 years, 5 months ago (2017-07-05 02:17:35 UTC) #4
yosin_UTC9
lgtm
3 years, 5 months ago (2017-07-05 02:29:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967973002/1
3 years, 5 months ago (2017-07-05 02:30:05 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 03:34:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b30a6dddc14804ad52d22db845f1...

Powered by Google App Engine
This is Rietveld 408576698