gpu: Reduce of BrowserGpuChannelHostFactory.

gpu: Reduce of BrowserGpuChannelHostFactory.

BrowserGpuChannelHostFactory will be replaced by ui::Gpu. So reduce
its usage. Most of the call-sites need just the base interface of
gpu::GpuChannelHostFactory. So provide a way to get to that from the
BrowserMainLoop singleton instance.

BUG=609316
Review-Url: https://codereview.chromium.org/2967963002
Cr-Commit-Position: refs/heads/master@{#484354}
Committed: https://chromium.googlesource.com/chromium/src/+/059bc5352b1cd9e29e8fc89ceffdb767a2bd2cca

[sadrul, 2017-07-05 01:36:59]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 01:37:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-07-05 01:43:50]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 01:43:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-07-05 02:10:45]

Description was changed from

==========
gpu: Reduce of BrowserGpuChannelHostFactory.

BrowserGpuChannelHostFactory will be replaced by ui::Gpu. So reduce
its usage. Most of the call-sites need just the base interface of
gpu::GpuChannelHostFactory. So provide a way to get to that from the
BrowserMainLoop singleton instance.

BUG=...
==========

to

==========
gpu: Reduce of BrowserGpuChannelHostFactory.

BrowserGpuChannelHostFactory will be replaced by ui::Gpu. So reduce
its usage. Most of the call-sites need just the base interface of
gpu::GpuChannelHostFactory. So provide a way to get to that from the
BrowserMainLoop singleton instance.

BUG=609316
==========

[commit-bot: I haz the power, 2017-07-05 03:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 03:18:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sadrul, 2017-07-05 05:03:14]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2017-07-05 05:03:15]

(Note that the test failure on the android trybot is fixed by
https://codereview.chromium.org/2969153002/)

[piman, 2017-07-05 17:48:16]

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_ipc_browsertests.cc (left):

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_ipc_browsertests.cc:133:
BrowserGpuChannelHostFactory::Initialize(false);
What is the replacement for this? Without this I'm afraid we'll introduce
flakiness.

[sadrul, 2017-07-05 18:39:52]

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_ipc_browsertests.cc (left):

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_ipc_browsertests.cc:133:
BrowserGpuChannelHostFactory::Initialize(false);
On 2017/07/05 17:48:15, piman wrote:
> What is the replacement for this? Without this I'm afraid we'll introduce
> flakiness.

The initialization in BrowserMainLoop [1] should always have created the
BrowserGpuChannelHostFactory instance by the time we reach here. So this (or
something equivalent) should not be needed here?

[1]
https://cs.chromium.org/chromium/src/content/browser/browser_main_loop.cc?sq=...

[sadrul, 2017-07-05 18:41:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 18:41:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2017-07-05 18:58:36]

lgtm

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_ipc_browsertests.cc (left):

https://codereview.chromium.org/2967963002/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_ipc_browsertests.cc:133:
BrowserGpuChannelHostFactory::Initialize(false);
On 2017/07/05 18:39:51, sadrul wrote:
> On 2017/07/05 17:48:15, piman wrote:
> > What is the replacement for this? Without this I'm afraid we'll introduce
> > flakiness.
> 
> The initialization in BrowserMainLoop [1] should always have created the
> BrowserGpuChannelHostFactory instance by the time we reach here. So this (or
> something equivalent) should not be needed here?
> 
> [1]
>
https://cs.chromium.org/chromium/src/content/browser/browser_main_loop.cc?sq=...

Ok, thanks. That probably explains some of the flakiness in tests and why
they're disabled on many platforms.

Maybe with the mojo refactoring we can make all this more testable.

[commit-bot: I haz the power, 2017-07-05 19:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 19:05:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sadrul, 2017-07-05 20:25:27]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-07-05 20:25:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 21:22:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499286327526600,
"parent_rev": "ee458c83c928a3c8bf1d5e067628309e5582c2c5", "commit_rev":
"059bc5352b1cd9e29e8fc89ceffdb767a2bd2cca"}

[commit-bot: I haz the power, 2017-07-05 21:22:32]

Description was changed from

==========
gpu: Reduce of BrowserGpuChannelHostFactory.

BrowserGpuChannelHostFactory will be replaced by ui::Gpu. So reduce
its usage. Most of the call-sites need just the base interface of
gpu::GpuChannelHostFactory. So provide a way to get to that from the
BrowserMainLoop singleton instance.

BUG=609316
==========

to

==========
gpu: Reduce of BrowserGpuChannelHostFactory.

BrowserGpuChannelHostFactory will be replaced by ui::Gpu. So reduce
its usage. Most of the call-sites need just the base interface of
gpu::GpuChannelHostFactory. So provide a way to get to that from the
BrowserMainLoop singleton instance.

BUG=609316

Review-Url: https://codereview.chromium.org/2967963002
Cr-Commit-Position: refs/heads/master@{#484354}
Committed:
https://chromium.googlesource.com/chromium/src/+/059bc5352b1cd9e29e8fc89ceffd...
==========

[commit-bot: I haz the power, 2017-07-05 21:22:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/059bc5352b1cd9e29e8fc89ceffd...