Issue 2967673002: Restore -rdynamic in Product mode build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2967673002: Restore -rdynamic in Product mode build (Closed)

Created:
3 years, 5 months ago by zra

Modified:
3 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Restore -rdynamic in Product mode build The flag is necessary for native extensions to work. There is a small increase in stripped binary size. Committed: https://github.com/dart-lang/sdk/commit/a8f85684f18186d145b49d7e2598536838e78a21

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/bin/BUILD.gn	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

zra

Committed patchset #1 (id:1) manually as a8f85684f18186d145b49d7e2598536838e78a21 (presubmit successful).

3 years, 5 months ago (2017-06-30 16:16:28 UTC) #5

Message was sent while issue was closed.

lgtm